Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0.1xx-sr7] [msbuild] Fix BundleResource defaults for iOS and MacCatalyst #23836

Merged
merged 2 commits into from
Jul 25, 2024
Merged

[release/8.0.1xx-sr7] [msbuild] Fix BundleResource defaults for iOS and MacCatalyst #23836

merged 2 commits into from
Jul 25, 2024

Commits on Jul 25, 2024

  1. [msbuild] Fix BundleResource defaults for iOS and MacCatalyst 

    Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2172694
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2172757

This PR #21350 added the new `PrivacyInfo.xcprivacy` to our default templates (new requirement from Apple) when building from Windows we try to bundle this resource and unfortunately we are missing the required Link metadata when this is done from single project triggering a condition where the path is incorrectly calculated when zipped in windows and once the zip archive is transfered to the mac host it is unable to unarchive the file. To fix this we simply unify the logic with what the macios SDK currently does [1] this ensures the right bundling happens.

[1]: https://github.com/xamarin/xamarin-macios/blob/main/dotnet/targets/Microsoft.Sdk.DefaultItems.template.props#L77
    @dalexsoto
    dalexsoto authored and github-actions committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    34b3bb1 View commit details
    Browse the repository at this point in the history

  2. Update Versions.props

    @PureWeen
    PureWeen authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    3c002fd View commit details
    Browse the repository at this point in the history