Remove assembly scanning from VisualTypeConverter #5102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
reviewed
Mar 7, 2022
eerhardt
reviewed
Mar 7, 2022
Comment on lines
33
to
34
| // Check for visual assembly attributes after scanning for IVisual Types | ||
| // this will let users replace the default visual names if they want to |
There was a problem hiding this comment.
This comment could use some updating, since we don't "scan for IVisual Types" anymore, so it isn't checked "after" anymore.
eerhardt
reviewed
Mar 7, 2022
| @@ -54,6 +55,8 @@ public void Register(Type tview, Type trender, Type[] supportedVisuals, short pr | |||
| } | |||
| else | |||
| visualRenderers[supportedVisuals[i]] = (trender, priority); | |||
|
|
|||
| RegisterVisual(supportedVisuals[i]); | |||
There was a problem hiding this comment.
You are probably getting ILLink warnings here since the supportedVisuals[i] isn't annotated as PublicParameterlessConstructor.
eerhardt
reviewed
Mar 7, 2022
Comment on lines
+99
to
+100
| name = name.Substring(0, name.Length - 6); | ||
| fullName = fullName.Substring(0, fullName.Length - 6); |
There was a problem hiding this comment.
Can we use ReadOnlySpan<char> and Slice here instead? Then below, when doing the comparisons, use SequenceEqual instead of ==.
And also not creating a new string appending Visual below. Just slice off "Visual" from visualName.
eerhardt
reviewed
Mar 7, 2022
| string name = visualType.Name; | ||
| string fullName = visualType.FullName; | ||
|
|
||
| if (name.EndsWith("Visual", StringComparison.OrdinalIgnoreCase)) |
There was a problem hiding this comment.
It's odd that we use IgnoreCase here, but don't do IgnoreCase below when comparing visualName == $"{name}Visual"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
builder.RegisterVisualinside theMicrosoft.Maui.Controls.Compatibility.Hostingnamespace so 3rd party libraries can register visuals as part of their builder codeIssues Fixed
Fixes #4937