Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually Update System.Text.Json from 8.0.0 to 8.0.3 #10002

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Manually Update System.Text.Json from 8.0.0 to 8.0.3 #10002

merged 4 commits into from
Apr 11, 2024

Conversation

surayya-MS
Copy link
Member

@surayya-MS surayya-MS requested a review from a team as a code owner April 11, 2024 15:27
@surayya-MS @rainersigwald
Update eng/Version.Details.xml
c512ccb 
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
rainersigwald
rainersigwald reviewed Apr 11, 2024
View reviewed changes
src/MSBuild/app.amd64.config Outdated Show resolved Hide resolved
src/MSBuild/app.config Outdated Show resolved Hide resolved
surayya-MS and others added 2 commits April 11, 2024 17:54
@surayya-MS @rainersigwald
Update src/MSBuild/app.amd64.config
d62fd17 
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
@surayya-MS @rainersigwald
Update src/MSBuild/app.config
6bfe54e 
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
rainersigwald
rainersigwald approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally I'd want an exp/ insertion to validate the VS side of these changes but since they've already gone ahead I think it makes sense to take this now and try to insert into that PR.

@surayya-MS surayya-MS merged commit 72d49c3 into dotnet:main Apr 11, 2024
9 checks passed
@Forgind
Copy link
Member

Forgind commented Apr 11, 2024

Does this break our S.T.J loading, or do we get binding redirected to the right version?
dotnet/sdk#39901

@rainersigwald
Copy link
Member

@Forgind dotnet/sdk#39901 (comment)

@surayya-MS surayya-MS deleted the update-system-text-json-8.0.3 branch April 12, 2024 07:56
ladipro added a commit that referenced this pull request Apr 12, 2024
@ladipro
Revert "Manually Update System.Text.Json from 8.0.0 to 8.0.3 (#10002)"
0c66e92 
This reverts commit 72d49c3.
ladipro added a commit that referenced this pull request Apr 15, 2024
@ladipro
Revert "Manually Update System.Text.Json from 8.0.0 to 8.0.3 (#10002)"
b91ebe0 
This reverts commit 72d49c3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes

@rainersigwald rainersigwald rainersigwald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@surayya-MS @Forgind @rainersigwald @YuliiaKovalova