Update AssignCulture Task to support existing Culture metadata #10026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
f-alizada
requested review from
MichalPavlik,
ladipro and
baronfel
and removed request for
baronfel and
rainersigwald
surayya-MS
approved these changes
Apr 26, 2024
surayya-MS
approved these changes
Apr 26, 2024
maridematte
approved these changes
Apr 26, 2024
rainersigwald
approved these changes
Apr 26, 2024
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9954
Context
Currently there is a difference in public documentation and actual implementation of AssignCulture task.
The difference:
If the incoming item from the Files parameter already contains a Culture metadata entry, the original metadata entry is used.In fact the Culture is not respected.
Please see the comment: #9954 (comment)
Changes Made
Update the AssignCulture task to include the property that will allow switch the way existing Culture metadata is handled.
Updated the Microsoft.Common.CurrentVersion.targets to make it possible to set the property on the project
Testing
Added unit test + manually tested on the local project.