Notify MSBuild TerminalLogger of project cache plugin run #10027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
With MSBuild terminal logger (TL) enabled, project cache plugin (PCP) command-line output suppresses important information, which indicates whether projects have finished upon cache hits.
With both TL and PCP enabled (for "Cache Hit" scenario):
Changes Made
Adds information per-project to determine whether the project is classified as a cache plugin project, which occurs when the cache plugin target is called (prior to
GetTargetPath
orBuild
). For cache plugin projects that are built, the scenario remains the same (the output path is shown). For cache plugin projects that result in a hit, indicate the output path as well to indicate build progression.Testing
This was tested with a custom package on the project cache plugin side to invoke the custom target and custom MSBuild bits, with TL and PCP enabled.
"Cache Hit" output:
"Cache Hit" (binlog):
"Cache Miss" output (same as before change):
"Cache Miss" (binlog):
Notes
N/A