Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete src/Deprecated #10352

Merged
merged 8 commits into from
Oct 27, 2024
Merged

Delete src/Deprecated #10352

merged 8 commits into from
Oct 27, 2024

Conversation

JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented Jul 10, 2024 •
edited
Loading

Fixes #8826

Context

Removal of the Deprecated code

Removals in VS codebase

@Forgind
Copy link
Member

Forgind commented Jul 12, 2024 •
edited
Loading

I know you said not to review, but I would be more than happy to just merge this 😁

@JanKrivanek
Copy link
Member Author

I know you said not to review, but I would be more than happy to just merge this 😁

100% 1000%! :-)

Though there is quite some process around this:

@JanKrivanek JanKrivanek mentioned this pull request Oct 11, 2024
Closed
31 tasks
@JanKrivanek JanKrivanek changed the title [Do not review] Delete src/Deprecated Delete src/Deprecated Oct 11, 2024
@JanKrivanek JanKrivanek marked this pull request as ready for review October 11, 2024 13:20
YuliiaKovalova
YuliiaKovalova approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@YuliiaKovalova YuliiaKovalova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a great work, Jan!

rainersigwald
rainersigwald approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will of course want this in its own insertion for easy problem-blaming.

. . . and I'm SO HAPPY!!!!!

src/Build/AssemblyInfo.cs Outdated Show resolved Hide resolved
@JanKrivanek @rainersigwald
Update src/Build/AssemblyInfo.cs
30624e1 
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
@JanKrivanek JanKrivanek enabled auto-merge (squash) October 27, 2024 18:52
@JanKrivanek JanKrivanek merged commit 5e119d7 into main Oct 27, 2024
10 checks passed
@JanKrivanek JanKrivanek deleted the JanKrivanek-remove-deprecated branch October 27, 2024 19:33
@JanKrivanek
Copy link
Member Author

I will of course want this in its own insertion for easy problem-blaming.

Dedicated insertion PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/588262

@JaynieBai JaynieBai mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

@maridematte maridematte maridematte approved these changes

@YuliiaKovalova YuliiaKovalova YuliiaKovalova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated engine code
5 participants
@JanKrivanek @Forgind @rainersigwald @maridematte @YuliiaKovalova