Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SequenceEqual in win32 GetFullPath #10706

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Use SequenceEqual in win32 GetFullPath #10706

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2a1728
Use SequenceEqual in win32 GetFullPath
rainersigwald Sep 25, 2024
aee35ff
fixup! Use SequenceEqual in win32 GetFullPath
rainersigwald Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Framework/NativeMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1546,6 +1546,7 @@ private static unsafe int GetFullPathWin32(string target, int bufferLength, char
/// <returns>True only if the contents of <paramref name="s"/> and the first <paramref name="len"/> characters in <paramref name="buffer"/> are identical.</returns>
private static unsafe bool AreStringsEqual(char* buffer, int len, string s)
{
#if CLR2COMPATIBILITY
if (len != s.Length)
{
return false;
Expand All @@ -1560,6 +1561,9 @@ private static unsafe bool AreStringsEqual(char* buffer, int len, string s)
}

return true;
#else
return MemoryExtensions.SequenceEqual(new ReadOnlySpan<char>(buffer, len), s.AsSpan());
#endif
}

internal static void VerifyThrowWin32Result(int result)
Expand Down
Loading