Remove BinFmt opt-in for un-exposed data transfers #10741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #AB2263324
Context
Opting out of 17.10 changewave might lead to opting out of BinaryFormatter deprecation. This can unintentionally break ppl builds by breaking NodeConfig or TaskHost config de/serialization.
Both of the types and their data transfer is internal to MSBuild - there is no need to opt out from the safer, proprietary de/serialization. Hence let's prevent the opt out altogether.
Changes Made
Removed the opt-out option for NodeConfig and TaskHost config de/serialization
Testing
Existing tests