-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS Insertion pipelines fix #10966
Merged
JanProvaznik
merged 4 commits into
dotnet:main
from
JanProvaznik:dev/janpro/fix-insertion-pipelines
Nov 19, 2024
Merged
VS Insertion pipelines fix #10966
JanProvaznik
merged 4 commits into
dotnet:main
from
JanProvaznik:dev/janpro/fix-insertion-pipelines
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this should wait for validating the insertions work after current issues get resolved. |
…pro/fix-insertion-pipelines
YuliiaKovalova
approved these changes
Nov 18, 2024
maridematte
reviewed
Nov 18, 2024
surayya-MS
approved these changes
Nov 19, 2024
This was referenced Nov 21, 2024
JaynieBai
pushed a commit
that referenced
this pull request
Dec 4, 2024
Backporting VS insertion pipelines Context #10966 #10920 #11037 Changes Made add pipeline Testing addressed in #11037 manually testing in azdo org for expected scenarios Notes backporting to vs17.8, vs17.10, vs17.11, vs17.12. Other branches are "out of regular support" and if insertion is needed they can be triggered from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new VS insertion pipelines introduced in #10920 did not work as expected, there was a mismatch which Artifacts were used. This PR addresses that and adds parameters to enable insertion from any branch.
Mitigate Guardian warning by deleting intermediate sourcebuild package.
Testing
Manual pipeline runs.