Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Insertion pipelines fix #10966

Merged

Conversation

JanProvaznik
Copy link
Member

The new VS insertion pipelines introduced in #10920 did not work as expected, there was a mismatch which Artifacts were used. This PR addresses that and adds parameters to enable insertion from any branch.
Mitigate Guardian warning by deleting intermediate sourcebuild package.

Testing

Manual pipeline runs.

@JanProvaznik
Copy link
Member Author

JanProvaznik commented Nov 11, 2024

Merging this should wait for validating the insertions work after current issues get resolved.

@JanProvaznik JanProvaznik marked this pull request as draft November 12, 2024 13:11
@JanProvaznik JanProvaznik marked this pull request as ready for review November 18, 2024 12:51
@JanProvaznik JanProvaznik changed the title Insertion pipelines fix VS Insertion pipelines fix Nov 19, 2024
@JanProvaznik JanProvaznik merged commit ea8de8e into dotnet:main Nov 19, 2024
10 checks passed
JaynieBai pushed a commit that referenced this pull request Dec 4, 2024
Backporting VS insertion pipelines

Context
#10966
#10920
#11037

Changes Made
add pipeline

Testing
addressed in #11037
manually testing in azdo org for expected scenarios

Notes
backporting to vs17.8, vs17.10, vs17.11, vs17.12. Other branches are "out of regular support" and if insertion is needed they can be triggered from main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants