[vs17.12] Always respect warning-as-error properties #10999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Remote (built in another node) projects were not respecting MSBuildWarningsNotAsErrors configured in the projects, when the API or CLI `-warnaserror` option was enabled. Fixes #10874.
maridematte
approved these changes
Nov 19, 2024
surayya-MS
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10892 to vs17.12
Work item (Internal use):
Summary
Respect warning-as-error settings configured per-project when
-warnaserroris passed on the command line.Customer Impact
Suppressing warnings is unnecessarily complicated and fails for confusing reasons.
Regression?
No, this behavior is longstanding, but the severity is higher with NuGet Audit because NuGet advises configuring warning-as-warning for audit warning codes.
Testing
Automated and targeted scenario tests.
Risk
Low: makes an existing opt-in codepath default.