Add a error/recap summary at the end of the build #11105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimaTian
reviewed
Dec 9, 2024
SimaTian
reviewed
Dec 9, 2024
rainersigwald
approved these changes
Dec 10, 2024
baronfel
reviewed
Dec 10, 2024
baronfel
approved these changes
Dec 10, 2024
SimaTian
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #10681
Context
In a very large build, errors may have scrolled well offscreen before the end of the build, leaving a terminal window with a sea of green "project succeeded" messages followed by an unhelpful "build failed with 8 errors".
Changes Made
TL can now display a summary of all errors and warnings in a structured way when the build finishes. For now, the only way to enable it is to use the logger parameter
-tlp:Summary. A heuristic method to determine when to automatically provide the summary will likely be added in a different PR.Testing
Manual testing + new automated test.
