Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ability for project properties to suppress and elevate warnings #1928

Merged
merged 3 commits into from
Apr 4, 2017

Commits on Apr 3, 2017

  1. Implement ability for project properties to suppress and elevate warn…

    …ings.
    
    Introduce MSBuildTreatWarningsAsErrors property that when set to true will treat all warnings as errors when building a project.
    Introduce MSBuildWarningsAsErrors property which is a semicolon delmited list of warning codes to treat as errors when building a project.
    Introduce MSBuildWarningsAsMessages property which is a semicolon delimited list of warning codes to treat as low importance messages.
    
    This allows users to control warnings at the project level via standard MSBuild properties.  They can be set in a project, an import, or from the command-line.
    
    The limitation here is that the warnings can only include ones that occur during a build.  This is because the properties are not read until after parsing so warnings generated during parse/evaluation happen too soon.  For these warnings, users will only be able to treat them as errors/messages with the /WarnAsError and /WarnAsMessage command-line arguments.
    
    Closes dotnet#1886
    jeffkl committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    de663ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a6af98a View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2017

  1. Remove projects from the dictionary after they've finished.

    Should reduce memory use when building large project trees
    jeffkl committed Apr 4, 2017
    Configuration menu
    Copy the full SHA
    a76a10c View commit details
    Browse the repository at this point in the history