Sync XSD "IntelliSense" with VS repo automatically on insertion #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Publish a new artifact `xsd` that has the XSDs and * A new script to copy those XSDs to the right place in VS when inserting MSBuild.
rainersigwald
added
the
Area: Our Own Build
rainersigwald
commented
Jul 20, 2020
| @@ -5624,7 +5624,7 @@ elementFormDefault="qualified"> | |||
| </xs:complexContent> | |||
| </xs:complexType> | |||
| </xs:element> | |||
|
|
|||
| <!-- a change made on GitHub that should flow --> | |||
There was a problem hiding this comment.
I should of course revert this proof that it worked.
rainersigwald
commented
Jul 20, 2020
src/MSBuild/Update-MSBuildXsds.ps1
Outdated
| @@ -0,0 +1,9 @@ | |||
| $ErrorActionPreference = 'Stop' | |||
|
|
|||
| cmd /c set | |||
Forgind
reviewed
Jul 20, 2020
This reverts commit db0ec71.
Forgind
approved these changes
Jul 20, 2020
| </None> | ||
| <None Include="Microsoft.Build.xsd"> | ||
| <SubType>Designer</SubType> | ||
| <XsdsForVS Include="**\*.xsd" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" /> |
There was a problem hiding this comment.
There are two "Default exclude" items here, so presumably "DefaultItemExcludes" doesn't include the "DefaultExcludesInProjectFolder". How does one know or find out how many default exclude items there are?
There was a problem hiding this comment.
There's probably a better way, but I build a project that excludes those, catch it in a debugger, break on the code that handles that in Project.cs, and inspect what it gets turned into.
There was a problem hiding this comment.
I'm following the SDK's approaches here:
No real way to know other than looking for analogies there that I know of.
ghost
added this to the
rainersigwald
added a commit
that referenced
this pull request
Aug 13, 2021
As of #5531, the manual XSD sync is no longer required.
Merged
rokonec
pushed a commit
that referenced
this pull request
Aug 16, 2021
As of #5531, the manual XSD sync is no longer required.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been manually managing this and naturally forgotten it a few times. That's not cool. Let's let a robot do it.
This requires change to the releases: https://dev.azure.com/devdiv/DevDiv/_releaseProgress?releaseId=749728&_a=release-history but it will be harmless to do this first and then change them.
Example internal PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/262150?_a=files