Support WarningsAsErrors as MSBuildWarningsAsErrors #5774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In same feature flag as NoWarn (can change to a separate feature flag if desired.)
sbomer
reviewed
Oct 5, 2020
benvillalobos
approved these changes
Oct 6, 2020
Forgind
changed the title
rainersigwald
requested changes
Oct 16, 2020
Co-authored-by: Sven Boemer <sbomer@gmail.com>
Forgind
changed the title
rainersigwald
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In same change wave as NoWarn (can change to a separate one if desired.)
@sbomer, here's WarnAsError. WarnNotAsError is a little more complicated, though I'd be happy to try to help if you want to try to implement it yourself.