Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Arcade 5.0 and .NET 5.0 #5836

Merged
merged 43 commits into from
Jan 20, 2021
Merged

Update to Arcade 5.0 and .NET 5.0 #5836

merged 43 commits into from
Jan 20, 2021

Commits on Jan 13, 2021

  1. Initial arcade update

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    fa19e25 View commit details
    Browse the repository at this point in the history

  2. set global.json back to 3.1.100

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    a08fe7a View commit details
    Browse the repository at this point in the history

  3. Fix roslyn folder to look for netcoreapp3.1

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    dc86d60 View commit details
    Browse the repository at this point in the history

  4. Add empty constructor?

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    f4d410f View commit details
    Browse the repository at this point in the history

  5. Revert "Fix roslyn folder to look for netcoreapp2.1". 

    This reverts commit bcfa960. Context
from Rainer: Arcade has an implicit version for
microsoft.net.compilers.toolset. It's ancient in arcade 1.0, newer in
5.0. We used to depend on the implicit version, so when I moved arcade
  it changed. Rainer recently made it explicit to the older version,
  thus we need to look back at netcoreapp2.1
    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    16ddaa0 View commit details
    Browse the repository at this point in the history

  6. Update to dotnet 5.0.100-rc.2.20479.15

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    a59a108 View commit details
    Browse the repository at this point in the history

  7. net5.0 was released already!

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    cf61235 View commit details
    Browse the repository at this point in the history

  8. Update versions.props to 5.0.100, how do we tie them together?

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    08e070d View commit details
    Browse the repository at this point in the history

  9. update dir.build.props and msft.build.csproj to use net5.0 targetfram… 

    …eworks
    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    6755fdd View commit details
    Browse the repository at this point in the history

  10. Update Directory.BeforeCommon.targets to account for net5.0

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    a47579d View commit details
    Browse the repository at this point in the history

  11. WIP: Set replace netcoreapp2.1 with net5.0

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    65892d5 View commit details
    Browse the repository at this point in the history

  12. Update (OS) to (OSEnvironment), nowarn on SYSLIB0011 (binaryformatter)

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    02d7cae View commit details
    Browse the repository at this point in the history

  13. Short out TPI

    @rainersigwald @benvillalobos
    rainersigwald authored and benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    bf12a8e View commit details
    Browse the repository at this point in the history

  14. Disambiguate order of operations 

    Between an `as` and string concatenations.
    @rainersigwald @benvillalobos
    rainersigwald authored and benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    bd02547 View commit details
    Browse the repository at this point in the history

  15. Initialize value passed to TranslateDotNet

    @rainersigwald @benvillalobos
    rainersigwald authored and benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    310e53b View commit details
    Browse the repository at this point in the history

  16. Relax nullable in COWDictionary deserialization 

    Since we control both sides of the serialization, just ! it.
    @rainersigwald @benvillalobos
    rainersigwald authored and benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    b6867fd View commit details
    Browse the repository at this point in the history

  17. Assume assembly path isn't a root

    @rainersigwald @benvillalobos
    rainersigwald authored and benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    e7b81b4 View commit details
    Browse the repository at this point in the history

  18. IsOS check for PipeDrain 

    This throws PNSE on non-Windows so just don't call it there.
    @rainersigwald @benvillalobos
    rainersigwald authored and benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    556bf53 View commit details
    Browse the repository at this point in the history

  19. Assume AssemblyName has a Name

    @rainersigwald @benvillalobos
    rainersigwald authored and benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    c51b459 View commit details
    Browse the repository at this point in the history

  20. Get rid of OsEnvironment

    @rainersigwald @benvillalobos
    rainersigwald authored and benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    1c17b5f View commit details
    Browse the repository at this point in the history

  21. fixup! IsOS check for PipeDrain

    @rainersigwald @benvillalobos
    rainersigwald authored and benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    e23a284 View commit details
    Browse the repository at this point in the history

  22. Roslyn update from PR dotnet#5920.

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    35adbc5 View commit details
    Browse the repository at this point in the history

  23. Update arcade scripts to net5.0

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    966b4e4 View commit details
    Browse the repository at this point in the history

  24. MSBuild.csproj no longer uses apphost. This fixes an issue where cert… 

    …ain tests would find MSBuild.exe AND MSBuild.dll when they should have only found msbuild.dll
    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    3ac093a View commit details
    Browse the repository at this point in the history

  25. Continue skipping over ValidateAssemblyLoadContext in net5.0

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    26809de View commit details
    Browse the repository at this point in the history

  26. Infinity is not a valid double

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    57b9fac View commit details
    Browse the repository at this point in the history

  27. Restore AssemblyLoadContext name 

    The with-a-name ctor wasn't available in .NET Core 2.1 but now is, so
use it and restore the test.
    @rainersigwald @benvillalobos
    rainersigwald authored and benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    47b749a View commit details
    Browse the repository at this point in the history

  28. look for netcoreapp2.1 arcade binaries

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    a334038 View commit details
    Browse the repository at this point in the history

  29. Revert to looking for arcade netcoreapp2.1 folder

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    18fa14f View commit details
    Browse the repository at this point in the history

  30. Update Microsoft.Extensions.DependencyModel and Runtime.CompilerServi… 

    …ces.Unsafe to 5.0.0
    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    195c471 View commit details
    Browse the repository at this point in the history

  31. Only import M.E.DependencyModel 5.0.0 when on net core

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    9ba9e5f View commit details
    Browse the repository at this point in the history

  32. Add special check for mono on mac to import M.E.DependencyModel 5.0.0… 

    …, short-circuiting the nonexistent IsTargetFrameworkCompatible intrinsic function on mono
    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    8579df7 View commit details
    Browse the repository at this point in the history

  33. remove osx check, keep monobuild check only

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    3d14064 View commit details
    Browse the repository at this point in the history

  34. Update arcade to fix signing issues

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    d1a83ca View commit details
    Browse the repository at this point in the history

  35. Remove stale comment, add comment explaining UseAppHost false

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    c4297a0 View commit details
    Browse the repository at this point in the history

  36. Update dotnetcliversion to 5.0.102

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    5d62686 View commit details
    Browse the repository at this point in the history

  37. Also update global.json and add a comment notifying future devs to up… 

    …date the version of DotNetCliVersion in versions.props AND global.json
    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    60ddd86 View commit details
    Browse the repository at this point in the history

  38. Simplify NetCoreBuild check. Use istargetframeworkcompatible with net… 

    …coreapp1.0 OR if TargetFramework starts with netstandard
    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    35fa031 View commit details
    Browse the repository at this point in the history

  39. Skip netcore check if on mono

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    36880b6 View commit details
    Browse the repository at this point in the history

  40. Catch-all condition for 'core-flavored' builds in the UpdateMSBuildDe… 

    …psFile target
    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    9eafc9c View commit details
    Browse the repository at this point in the history

  41. Fix condition

    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    72ef461 View commit details
    Browse the repository at this point in the history

  42. Prevent mono builds from seeing IsTargetFrameworkCompatible intrinsic… 

    … function (that doesn't exist in mono builds)
    @benvillalobos
    benvillalobos committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    57fde7f View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Merge branch 'master' into arcade-update

    @benvillalobos
    benvillalobos committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    e80a52b View commit details
    Browse the repository at this point in the history