Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to json serialization without adding support for precomputed caches #5983

Closed
wants to merge 43 commits into from

Commits on Jul 14, 2020

  1. First stab at caching more RAR info

    This gives RAR the ability to save off a modified state file and load it for later use.
    
    Still to do:
    1) Verify that the precomputed cache read in is real.
    2) Change logging such that it will log messages instead of errors or warnings if there are problems with deserializing the precomputed cache
    3) Comments at relevant points
    4) Switch serialization mode to another form (json?)
    5) Validation + performance tests
    6) Have SDK opt in
    Forgind committed Jul 14, 2020
    Configuration menu
    Copy the full SHA
    a79f308 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. PR comments pt. 1

    Forgind committed Jul 21, 2020
    Configuration menu
    Copy the full SHA
    1d73559 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    036c5a3 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2020

  1. Next steps

    Forgind committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    8b3b613 View commit details
    Browse the repository at this point in the history
  2. revert to BinaryFormatter

    Forgind committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    6160d48 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2020

  1. Serialize mvid

    Forgind committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    9b95494 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2020

  1. Design change

    Forgind committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    43195f4 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Serialize AssemblyNameExtension

    It was previously serializable via BinaryFormatter. This makes it serializable via System.Text.Json's JsonConverter.
    Forgind committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    9045d3d View commit details
    Browse the repository at this point in the history
  2. Serialize SystemState

    Add support for serializing SystemState using System.Text.Json rather than the older BinaryFormatter.
    Forgind committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    ecf24de View commit details
    Browse the repository at this point in the history
  3. Opt into new serialization behavior for all serialization rather than…

    … just when serializing and deserializing the precomputed cache
    Forgind committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    b25d160 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9fa92fb View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. PR comments

    I have not yet measured how long it takes to read a MVID vs. reading and parsing its references, nor have I made unit tests.
    Forgind committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    5608066 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Configuration menu
    Copy the full SHA
    ccb508d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    354de87 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fd76e0b View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Fix generic

    Forgind committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    b1a7695 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d71f2a6 View commit details
    Browse the repository at this point in the history
  3. Build

    Forgind committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    fbe1028 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2020

  1. Fix bad changes

    Forgind committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    d790150 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Added tests 1

    Forgind committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    a759006 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. Finish tests

    ...although they don't work yet
    Forgind committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    767f1cc View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. Configuration menu
    Copy the full SHA
    412c21b View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Configuration menu
    Copy the full SHA
    0450dd2 View commit details
    Browse the repository at this point in the history
  2. Small fixups

    Forgind committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    9f930f4 View commit details
    Browse the repository at this point in the history
  3. Make constructor internal

    Forgind committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    58217f6 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. PR feedback

    Forgind committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    2043c3f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    853fd38 View commit details
    Browse the repository at this point in the history
  3. Real ANE

    Forgind committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    bda6b37 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a2c0f42 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d92e5da View commit details
    Browse the repository at this point in the history
  6. fixed test

    Forgind committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    37a7583 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. Update versions

    The version of Arcade MSBuild currently uses uses Roslyn version 3.3.1. This updates that, but it should be removed when we've updated to a more modern version of arcade.
    Forgind committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    a557722 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'update-versions' of https://github.com/forgind/msbuild

    …into json-serialization
    Forgind committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    5a6851f View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2020

  1. Remove MVID check

    Forgind committed Dec 4, 2020
    Configuration menu
    Copy the full SHA
    59aaab1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df2d5c9 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. Merge branch 'json-serialization' of https://github.com/forgind/msbuild

    … into serialization-only
    Forgind committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    b2f7507 View commit details
    Browse the repository at this point in the history
  2. Remove precomputed cache

    Forgind committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    11978bb View commit details
    Browse the repository at this point in the history
  3. Add fallback cache creation

    Forgind committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    fcbeb81 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. PR comments

    Forgind committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    2f3ed8d View commit details
    Browse the repository at this point in the history
  2. Switch to async

    Forgind committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    08aede6 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2020

  1. Make tests pass

    Forgind committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    01a3b56 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Use frameworkName

    Forgind committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    63f4b00 View commit details
    Browse the repository at this point in the history
  2. Add comment

    Forgind committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    d50dbb4 View commit details
    Browse the repository at this point in the history