Use logical core count #6014
Merged
Use logical core count #6014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdmihai
force-pushed
the
useLogicalCoreCount
branch
from
dc27d1d
to
e8ad375
Compare
cdmihai
force-pushed
the
useLogicalCoreCount
branch
from
e8ad375
to
4517ab4
Compare
rainersigwald
requested changes
Jan 8, 2021
There was a problem hiding this comment.
😅 Guess I didn't self-build on that big machine I borrowed to test this.
fyi @mfkl
| @@ -1725,7 +1725,7 @@ internal static void GatherCommandLineSwitches(ArrayList commandLineArgs, Comman | |||
| if (String.Equals(switchName, "m", StringComparison.OrdinalIgnoreCase) || | |||
| String.Equals(switchName, "maxcpucount", StringComparison.OrdinalIgnoreCase)) | |||
| { | |||
| int numberOfCpus = Environment.ProcessorCount; | |||
| int numberOfCpus = NativeMethodsShared.GetLogicalCoreCount(); | |||
There was a problem hiding this comment.
Suggested change
| int numberOfCpus = NativeMethodsShared.GetLogicalCoreCount(); | |
| int numberOfCpus = Environment.ProcessorCount; |
The change wave won't apply otherwise. Which actually suggests that we should consider putting all of the logic here into NativeMethodsShared since it can be centralized.
There was a problem hiding this comment.
I moved the xmake logic instead: d5ac55a
I think this is the correct way to do it, didn't realize the thing can return -1 :)
|
Where can I get that many cores!? |
rainersigwald
approved these changes
Jan 15, 2021
Forgind
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test started failing after upgrading my machine to 18 cores:
So I changed all occurrences of Environment.ProcessorCount to NativeMethodsShared.GetLogicalCoreCount