-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove more unnecessary NuGet package references. #6036
Conversation
Not trivially, because we often have to coordinate with other repos and Visual Studio itself. I started taking a crack at this in #5910 but got bogged down and probably won't finish before I head out on parental leave. |
Congratulations!! 🥳👶🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments from the PR review meeting: Any PackageReference
items that were removed should also remove the equivalent PackageReference
in the eng\Packages.props
file.
Done @benvillalobos. I also cleaned-up all unused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Our master branch is temporarily closed to new commits, but we'll merge this soon. Thanks for this!
Thanks @teo-tsirpanis! |
A continuation of #5242, this PR removes more NuGet packages, some of which were added later.
I have seen that some packages like
System.Collections.Immutable
were updated to version 5.0.0. Can I do the same for the other system packages as well?