Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more unnecessary NuGet package references. #6036

Merged
merged 5 commits into from
Feb 9, 2021
Merged

Remove more unnecessary NuGet package references. #6036

merged 5 commits into from
Feb 9, 2021

Conversation

teo-tsirpanis
Copy link
Contributor

A continuation of #5242, this PR removes more NuGet packages, some of which were added later.


I have seen that some packages like System.Collections.Immutable were updated to version 5.0.0. Can I do the same for the other system packages as well?

@rainersigwald
Copy link
Member

I have seen that some packages like System.Collections.Immutable were updated to version 5.0.0. Can I do the same for the other system packages as well?

Not trivially, because we often have to coordinate with other repos and Visual Studio itself. I started taking a crack at this in #5910 but got bogged down and probably won't finish before I head out on parental leave.

@teo-tsirpanis
Copy link
Contributor Author

I head out on parental leave

Congratulations!! 🥳👶🏻

Copy link
Member

@benvillalobos benvillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@benvillalobos benvillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from the PR review meeting: Any PackageReference items that were removed should also remove the equivalent PackageReference in the eng\Packages.props file.

@teo-tsirpanis
Copy link
Contributor Author

Done @benvillalobos. I also cleaned-up all unused Packages.props entries.

Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Our master branch is temporarily closed to new commits, but we'll merge this soon. Thanks for this!

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jan 21, 2021
@Forgind Forgind merged commit 9657f12 into dotnet:master Feb 9, 2021
@Forgind
Copy link
Member

Forgind commented Feb 9, 2021

Thanks @teo-tsirpanis!

@teo-tsirpanis teo-tsirpanis deleted the nuget-cleanup branch February 9, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants