Pass $(Nullable) to csc in XamlPreCompile #6093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgind
approved these changes
Jan 28, 2021
benvillalobos
approved these changes
Jan 29, 2021
benvillalobos
added
the
merge-when-branch-open
|
Thanks @huoyaoyuan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6088
Context
$(Nullable) not passed into csc invoked in XamlPreCompile, causing nullable waring in project with xaml and nullable enabled
Changes Made
Passes $(Nullable) as targets in roslyn
Testing
None
Notes
I wonder what are involved by this issue. WPF (.NET Core) is not involve.
Technically this is a critical bug to every version after 16.3 because it blocks WarningAsError.