Miscellaneous refactors in Common props, targets and tasks #6161
Conversation
Fixes #1062 ### Context The import based on this property was introduced as a temporary bootstrapping mechanism before there was packaging extensibility available for multi-targeting. The packaging mechanism (aka NuGet) now uses `buildCrossTargeting`/`buildMultiTargeting`, similar to `build` package folder to hold and import multi-targeting logic via NuGet's Restore. Thus, we don't need this workaround anymore. ### Changes Made Removed the temporary import based on `CoreCrossTargetingTargetsPath` ### Testing Since there are no tests for this property, as it is with all the workarounds… We'll see if we break anyone during the self-hosting period. ### Notes This patch was already a part of #6161. Since, the change was approved independently, I have separated this into a new PR.
This reverts commit 0e4b0c2.
Make Common props, targets and tasks easier to read and understand.
Ensure they follow consistent formatting
E.g.: 2-space indent
```xml
<!-- Single Line Comment Text -->
<!--
Multi Line Comment Text
Another Comment Text
Indented Comment Text
-->
```
Make Common props, targets and tasks easier to read and understand. in all files: - Fix improper leading and trailing spacing of strings within quotes. in 'Microsoft.Common.props': - Move 'BaseIntermediateOutputPath' logic out of 'MSBuildProjectExtensionsPath' block. in 'Microsoft.Common.CrossTargeting.targets': - Remove temporary import depending on 'CoreCrossTargetingTargetsPath' property. in 'Microsoft.Common.CurrentVersion.targets': - Add single quotes to property names in text. - Set 'ProjectPath' to the now available 'MSBuildProjectDirectory'. - Simplified condition logic wherever based on 'OutputType' property. - Use 'ConfigurationName' property instead of 'Configuration' property.
|
Some of your PRs have been open (and drafts) for a very long time. Are you still working on any of them? Would you mind if I close some? |
|
Yes, I'm and I have pushed my commits but not reflecting latest changes. I don't know why! Some of them are finished too but the latest changes are not reflecting. |
|
What did you push to? I looked at the branch for this PR in your repo, and it seems to be 3 commits ahead of main, just as this PR is. |
|
You can see from the above image; the branch has been struck out with a tooltip saying "repository is deleted". I suspect it's because of re-forking MSBuild repo I did due to dependabot issues. |
|
@Forgind Closing this since I re-forked the repo, the branch ref to this PR was removed as well. I'll open a new PR soon. BTW PR 7168 has been completed, can you look into why it hasn't been merged all this time? |
Fixes #TBA
Context
Make Common props, targets and tasks easier to read and understand.
Changes Made
Common changes in all files
Fix improper leading and trailing spacing of strings within quotes.
Microsoft.Common.propsMicrosoft.Common.CurrentVersion.targetsProjectPathto the now availableMSBuildProjectDirectory.OutputTypeproperty.ConfigurationNameproperty instead ofConfigurationproperty.TBA
Testing
NIL
Notes
I'll make sure that there's no functional changes in these refactors. If they do have, I'll create a separate PR for those.
I'll also separate the commits by common refactors and have a last one or two commits containing everything else to make reviewing easier.
For now, I'm placing this in Draft since there are many refactors to be added.
Please hold up your reviews until it's out of draft.