Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General "switch" description in help message - update for "--" indicator #6205

Merged
merged 2 commits into from
Mar 11, 2021

Conversation

BartoszKlonowski
Copy link
Contributor

This pull request updates the general "switch" description in the help message.
This can be considered as a follow-up of #5786 delivery, where double-dash switch indicator has been added.


The changes contain:

  • Help message update: added third indicator's option and removed "both" as it's now invalid
  • Applied changes to the localizations

After adding support for both "--" and "-" switch indicators, the help
message became outdated. It still mentiones only "-" and "/" indicators,
which can be confusing.
This commit fixes it by updating the description of the main text.
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

<value>Switches: Note that you can specify switches using both
"-switch" and "/switch".
<value>Switches: Note that you can specify switches using
"-switch", "/switch" and "--switch".
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit:

Suggested change
"-switch", "/switch" and "--switch".
"-switch", "/switch", and "--switch".

I like Oxford commas 😉

Copy link
Member

@benvillalobos benvillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benvillalobos benvillalobos added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Mar 5, 2021
@rokonec rokonec merged commit be34064 into dotnet:master Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants