Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jnm2.ReferenceAssemblies.net35 should be a private dependency #6214

Merged
merged 1 commit into from
Mar 3, 2021
Merged

jnm2.ReferenceAssemblies.net35 should be a private dependency #6214

merged 1 commit into from
Mar 3, 2021

Conversation

dfederm
Copy link
Contributor

@dfederm dfederm commented Mar 2, 2021

Fixes #6213

@dfederm
Copy link
Contributor Author

dfederm commented Mar 2, 2021

@ladipro @Forgind @cdmihai @rainersigwald

sharwell
sharwell approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also verified that the other reference assembly packages already set the same attribute.

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Mar 2, 2021
@benvillalobos benvillalobos merged commit 95415a2 into dotnet:master Mar 3, 2021
@dfederm dfederm deleted the dfederm/net35-private branch March 4, 2021 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

@cdmihai cdmihai cdmihai approved these changes

@benvillalobos benvillalobos benvillalobos approved these changes

Assignees
No one assigned
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jnm2.ReferenceAssemblies.net35 is not a private development dependency
5 participants
@dfederm @sharwell @cdmihai @benvillalobos @Forgind