Ignore invalid import when expression empty #6222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdmihai
approved these changes
Mar 4, 2021
Forgind
approved these changes
Mar 5, 2021
Forgind
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6221
Context
When the project load setting
IgnoreInvalidImportsis set, the caller expects imports that couldn't be loaded to just be ignored in a best effort attempt to load the project. However, the code path of the project expression evaluating to an empty string was overlooked in #2720Changes Made
I've checked the
ProjectLoadSettingsin the evaluator when the project import expression evaluates to an empty string and logged an event and skipped the importTesting
I've added a unit test
Notes
The first commit is the implementation, the second commit is just a conversion to Shouldly