Improve doc comments #6284
Improve doc comments #6284
Conversation
| /// <remarks> | ||
| /// An example value is "5.1.2600.0" for Windows XP. | ||
| /// If you don't specify a value, a default value is used. | ||
| /// The default value is the minimum supported OS of the .NET Framework, which is "4.10.0.0" for Windows 98 Second Edition. |
There was a problem hiding this comment.
@danmoseley Should this MSBuild logic be updated since Windows 98 is no longer supported?
There was a problem hiding this comment.
This isn't my code/product. I believe this relates to ClickOnce which I don't think (?) is under active development. So my inclination if I owned this would be to not touch functionality unless I have to. I would just update the comment as seems best. It doesn't seem very consequential if it's not quite right.
There was a problem hiding this comment.
Team triage: We've seen some PRs from ClickOnce, so it still seems to be under active development. @sujitnayak and @John-Hart can comment on whether they want to make a change, though I agree it doesn't seem too consequential.
There was a problem hiding this comment.
ClickOnce is still supported and in fact, we have updated this recently for .NET Core, but as to which versions of Windows and .NET that are supported or the defaults is more of a ClickOnce Runtime question for either @merriemcgaw or @NikolaMilosavljevic
There was a problem hiding this comment.
@merriemcgaw, @NikolaMilosavljevic, update?
There was a problem hiding this comment.
I don't think we should modify the default supported OS. Let's keep the old value intact. Customers can always modify this on their own.
Forgind
added
merge-when-branch-open
Forgind
added
the
merge-when-branch-open
cc @ghogen
Contributes to dotnet/dotnet-api-docs#2053.
For doc comment guidelines, see https://github.com/dotnet/dotnet-api-docs/wiki.