Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to V3 publishing #6349

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Conversation

benvillalobos
Copy link
Member

Context

V3 publishing is much faster and is required for publishing to the "VS 17.0" channel.

Changes Made

Followed this: https://github.com/dotnet/arcade/blob/main/Documentation/CorePackages/Publishing.md#how-to-upgrade-from-v2-to-v3

Add eng\publishing.props with single propertygroup PublishingVersion set to 3.
Pass publishingInfraVersion: 3 to post-build yml.

Testing

Should launch an exp/ branch to verify this

Added exp/bevillal/v3-publish-test as a default channel to "VS 17.0" and kicked off a pipeline build here: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=4655204&view=results

  • Remove exp/bevillal/v3-publish-test as a default channel from "VS 17.0"

This is required for pushing packages up to the "VS 17.0" channel.
@benvillalobos
Copy link
Member Author

@epananth
Copy link
Member

The build did not kick off maestro promotion pipeline. I checked the darc get-build

darc get-build --id 86878
Repository:    https://dev.azure.com/devdiv/DevDiv/_git/DotNet-msbuild-Trusted
Branch:        refs/heads/bevillal/v3-publish-test
Commit:        be418e2d9904cd12548d6b64b1a68effcf3bae8f
Build Number:  20210420.1
Date Produced: 4/19/2021 4:40 PM
Build Link:    https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=4667988
BAR Build Id:  86878
Released:      False
Channels:

The build is using the azdo internal repo url instead of the translated github url.

Is there any reason why we cannot get the latest from .NET Eng - Latest channel?

@benvillalobos
Copy link
Member Author

@epananth That would be pending #6143, as we're not on net6.0 just yet.

@benvillalobos
Copy link
Member Author

@epananth I think your concern would be solved by this PR: dotnet/arcade#7267

@benvillalobos benvillalobos marked this pull request as ready for review April 21, 2021 17:52
@benvillalobos
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epananth
Copy link
Member

@MattGal is making a fix in arcade-validation to get this unblocked. I was able to test the changes he merged

https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=4677589&view=results

@epananth
Copy link
Member

It will be good to run a test again..

@epananth
Copy link
Member

Yaaay! finally :)

@benvillalobos benvillalobos merged commit 500b60a into dotnet:main Apr 22, 2021
@benvillalobos benvillalobos deleted the arcade-v3-publishing branch April 22, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants