Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vs16.11] Update dependencies from dotnet/arcade #7332

Merged
merged 5 commits into from
Mar 3, 2022
Merged

[vs16.11] Update dependencies from dotnet/arcade #7332

merged 5 commits into from
Mar 3, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 25, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 82cd8e70-8184-4057-ccfc-08d9301a11ed
  • Build: 20220223.4
  • Date Produced: February 23, 2022 10:29:12 PM UTC
  • Commit: 295d305a5520815cbf4ccb3f209f6ee8ba11b45d
  • Branch: refs/heads/release/5.0

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
69009f8 
…105.3

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21505.11 -> To Version 5.0.0-beta.22055.3
@ladipro
Copy link
Member

ladipro commented Jan 26, 2022 

##[warning]An image label with the label macOS-10.14 does not exist.

Let's see if it's a fluke.

@ladipro
Copy link
Member

ladipro commented Jan 26, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AR-May
Copy link
Member

AR-May commented Feb 3, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
c86c9e2 
…204.7

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21505.11 -> To Version 5.0.0-beta.22104.7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
dd27908 
…222.5

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21505.11 -> To Version 5.0.0-beta.22122.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20220…
d48aa23 
…223.4

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21505.11 -> To Version 5.0.0-beta.22123.4
@Forgind
Copy link
Member

Forgind commented Mar 1, 2022 

##[warning]An image label with the label macOS-10.14 does not exist.

Let's see if it's a fluke.

Not a fluke. That image was deprecated December 2021:
https://devblogs.microsoft.com/devops/hosted-pipelines-image-deprecation/

I can push a fix.

@Forgind Forgind requested a review from ladipro March 1, 2022 23:49
ladipro
ladipro approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@ladipro ladipro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Forgind! So we need the fix to be able to build 16.11 in case we service it. Do we also need the Arcade update? I seem to remember we had a discussion around this but not sure what the outcome was.

@Forgind
Copy link
Member

Forgind commented Mar 2, 2022

Thank you @Forgind! So we need the fix to be able to build 16.11 in case we service it. Do we also need the Arcade update? I seem to remember we had a discussion around this but not sure what the outcome was.

I think so? In any case, we can presumably not insert, and if we have to service 16.11, we can bring them in together—I don't think a qb would have a problem with a little infrastructure in addition to a change.

@rainersigwald
Copy link
Member

There will be some Arcade updates that are absolutely required to build for servicing. And some that aren't completely required. And it won't be easy to figure out which is which, so I tend to favor just taking them.

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Mar 2, 2022
@AR-May AR-May merged commit 14052b1 into vs16.11 Mar 3, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-vs16.11-8ac9acb7-36c0-4a53-a3b2-c4e098a9a0bd branch March 3, 2022 13:45
@AR-May AR-May mentioned this pull request Dec 20, 2022
Merged
AR-May added a commit that referenced this pull request Dec 21, 2022
@AR-May
Merge pull request #8260 from dotnet/exp/AR-May/opt-prof-fix-vs16.11-…
d9f4185 
…to-vs17.0-2

Backport opt-prof v2 vs17.0 

- [vs16.11] Update dependencies from dotnet/arcade (#7332)
- Update dependencies from https://github.com/dotnet/arcade build 20220309.5
- Update dependencies from https://github.com/dotnet/arcade build 20220526.2
- Bump CLI version to match global.json
- Bump NuGet version to match
- Avoid AssemblyName.KeyPair on .NET (#7660)
- Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11
- Merge pull request #7663 from rainersigwald/backport-keypair-elision-16.11
- Configure OptProf v2 pipeline 16.11 (#8189)
- Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12'
- Move BAR publish to windows-latest
- Merge pull request #8210 from rainersigwald/exp/16.11-build

### Testing
CI, Opt-prof CI
@AR-May AR-May mentioned this pull request Dec 22, 2022
Merged
AR-May added a commit that referenced this pull request Jan 10, 2023
@AR-May
Merge pull request #8264 from AR-May/exp/AR-May/opt-prof-fix-vs17.0-t…
94fcedf 
…o-vs17.2

Backport opt-prof v2 vs17.2

Brings the following changes from the 17.0 branch into 17.2:
- [vs16.11] Update dependencies from dotnet/arcade (#7332)
- Update dependencies from https://github.com/dotnet/arcade build 20220309.5
- Update dependencies from https://github.com/dotnet/arcade build 20220526.2
- Bump CLI version to match global.json
- Bump NuGet version to match
- Avoid AssemblyName.KeyPair on .NET (#7660)
- Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11
- Merge pull request #7663 from rainersigwald/backport-keypair-elision-16.11
- Configure OptProf v2 pipeline 16.11 (#8189)
- Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12'
- Move BAR publish to windows-latest
- Merge pull request #8210 from rainersigwald/exp/16.11-build
- Merge remote-tracking branch 'upstream/vs16.11' into exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2
- Merge pull request #8260 from dotnet/exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2

### Testing
CI
@AR-May AR-May mentioned this pull request Jan 12, 2023
Merged
AR-May added a commit that referenced this pull request Jan 19, 2023
@AR-May
Merge pull request #8304 from dotnet/dev/AR-May/opt-prof-fix-vs17.2-t…
fedecea 
…o-vs17.4

Backport opt-prof v2 vs17.4

Brings the following changes from the 17.2 branch into 17.4:
- [vs16.11] Update dependencies from dotnet/arcade (#7332)
- Update dependencies from https://github.com/dotnet/arcade build 20220309.5
- Update dependencies from https://github.com/dotnet/arcade build 20220526.2
- Bump CLI version to match global.json
- Bump NuGet version to match
- Avoid AssemblyName.KeyPair on .NET (#7660)
- Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11
- Merge pull request #7663 from rainersigwald/backport-keypair-elision-16.11
- Configure OptProf v2 pipeline 16.11 (#8189)
- Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12'
- Move BAR publish to windows-latest
- Merge pull request #8210 from rainersigwald/exp/16.11-build
- Merge remote-tracking branch 'upstream/vs16.11' into exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2
- Merge pull request #8260 from dotnet/exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2
- Merge remote-tracking branch 'upstream/vs17.0' into exp/AR-May/opt-prof-fix-vs17.0-to-vs17.2
- Merge pull request #8264 from AR-May/exp/AR-May/opt-prof-fix-vs17.0-to-vs17.2

### Testing
CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladipro ladipro ladipro approved these changes

Assignees
No one assigned
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ladipro @AR-May @Forgind @rainersigwald