Skip TerminalLogger in context of dotnet test #9066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladipro
approved these changes
Jul 26, 2023
ladipro
reviewed
Jul 26, 2023
rainersigwald
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9061
Context
#9061
This is the proposal of option a) (disabling
TerminalLoggerentirely fordotnet test)UX
Note
The approach b) (disabling
TerminalLoggeronly for the test part of thedotnet test) turns out to be not 'hardenable' enough for multi-project solutions due to the fact that MSTest and MSBuild race with writing to a single console and MSBuild might not be quick enough to teporarily pause it's updates.It looks workable for simple solutions - sample just for reference: