Fixing nowarn flakiness - warnings config is stored by compound key #9162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
approved these changes
Aug 24, 2023
rainersigwald
approved these changes
Aug 24, 2023
|
is it too late to backport this to .net 8? |
|
nvm it made it to .net 8 dotnet/sdk#34908 |
|
@kasperk81 yeah, we'll be in .NET 8 for a while yet, until we branch for 17.9. As a "tooling" repo that ships to Visual Studio and .NET we have slightly different timelines from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9133
Context
NoWarnhas become flaky in all build configurations and frequently not suppresing given warnings as errors.During analysis I have found out our
LoggingServiceis storing suppressed warning codes list by key which was weakly hashed with lots of possible collisions in expected input ranges.When any project finishes its Warning configuration is removed from
LogginService warnign configs dictionary, if just finished project have had collision key it removed the "other-guy" data.Changes Made
Changed to compound key as
readonly record struct.Since we have smallish numbers of warnings during build I do not believe it have measurable perf degradation.
Testing
Notes
Every time junior developer have had come to me with possible root cause "What if it is hash collision" I hushed them with automatic "Oh. please".
But this time it really is hash collision :-)