Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file #9530

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add CODEOWNERS file #9530

merged 1 commit into from
Dec 13, 2023

Conversation

AR-May
Copy link
Member

@AR-May AR-May commented Dec 13, 2023

Fixes #9513

Context

Creation of CODEOWNERS file as per request in issue. Having a code owners file would also be generally useful when opening PRs in this repo, as it can sometimes be difficult and time consuming to determine who should be included as a reviewer.

Changes Made

Added @dotnet/source-build-internal as code owners for SB files
Added @dotnet/kitten as code owner for some of files and folders.

Testing

No testing

@ghost
Copy link

ghost commented Dec 13, 2023

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

@rainersigwald
Copy link
Member

To resolve

Unknown owner on line 4: make sure the team @dotnet/source-build-internal exists, is publicly visible, and has write access to the repository
/eng/SourceBuild*       @dotnet/source-build-internal

I added @dotnet/source-build-internal as repo writers. Please don't abuse the privilege :)

@AR-May AR-May merged commit 5df2181 into dotnet:vs17.9 Dec 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants