Right justify in terminal logger (17.9 #9534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the rendered string, with its invisible control characters.
I wanted control over equality, and we don't need the auto-generated stuff.
Move cursor right (it stops at end of line), then back to justify the output. This makes the localization less flexible since the formatting + justification is handled in code, but makes it a lot easier to understand. In the future reordering in translations would need to be handled fairly carefully. Avoid a bunch of overwrite problems by simplifiying the should-we-do-a-fancy-overwrite decision to "is just time tick" or "just overwrite it all".
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
AR-May
approved these changes
Dec 13, 2023
ladipro
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #9053 to 17.9, which is where we had agreed to put it but I forgot to retarget the PR :-/