Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ConfigurableForwardingLogger #9578

Merged
merged 4 commits into from
Jan 6, 2024

Conversation

JanKrivanek
Copy link
Member

@JanKrivanek JanKrivanek commented Dec 29, 2023

Context

Random find - ConfigurableForwardingLogger is checking a string dictionary for each build event, while a simple events (un)subscriptions can achieve same job with less efforts (coding and CPU)

Testing

Existing tests (ConfigureableForwardingLogger_Tests)

@JanKrivanek JanKrivanek marked this pull request as ready for review December 29, 2023 14:09
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♥️

@JanKrivanek
Copy link
Member Author

JanKrivanek commented Jan 3, 2024

Done

Note - I accidentally eddited the Deprecated sources version - so porting the changes to the proper source

Btw. - I cannot wait till we'll finally geer rid of the Deprecated sources!! :-)

Copy link
Contributor

@rokonec rokonec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous review was without last commit, now it looks good to go.

@JanKrivanek JanKrivanek merged commit c49f2e3 into dotnet:main Jan 6, 2024
8 checks passed
@JanKrivanek JanKrivanek deleted the proto/FwdingLogger-improve branch January 6, 2024 19:47
@ladipro
Copy link
Member

ladipro commented Jan 16, 2024

@JanKrivanek this change broke terminal logger output, can you please investigate?

To reproduce, build the MSBuild repo with /tl. With this change it's missing most of the Project tfm succeeded (N.Ns) → path/to/output log lines.

Good:
image
<snip>

Bad:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants