-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ConfigurableForwardingLogger #9578
Improve ConfigurableForwardingLogger #9578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Deprecated/Engine/Logging/DistributedLoggers/ConfigurableForwardingLogger.cs
Outdated
Show resolved
Hide resolved
src/Deprecated/Engine/Logging/DistributedLoggers/ConfigurableForwardingLogger.cs
Outdated
Show resolved
Hide resolved
Done
Btw. - I cannot wait till we'll finally geer rid of the Deprecated sources!! :-) |
9831997
to
0c161a0
Compare
src/Build/Logging/DistributedLoggers/ConfigurableForwardingLogger.cs
Outdated
Show resolved
Hide resolved
src/Build/Logging/DistributedLoggers/ConfigurableForwardingLogger.cs
Outdated
Show resolved
Hide resolved
src/Build/Logging/DistributedLoggers/ConfigurableForwardingLogger.cs
Outdated
Show resolved
Hide resolved
src/Build/Logging/DistributedLoggers/ConfigurableForwardingLogger.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous review was without last commit, now it looks good to go.
@JanKrivanek this change broke terminal logger output, can you please investigate? To reproduce, build the MSBuild repo with |
Context
Random find -
ConfigurableForwardingLogger
is checking a string dictionary for each build event, while a simple events (un)subscriptions can achieve same job with less efforts (coding and CPU)Testing
Existing tests (
ConfigureableForwardingLogger_Tests
)