Condition source-build specific configurations on DotNetBuildFromSouce

[ViktorHofer]

Contributes to VMR work: dotnet/source-build#3926

Changes are from dotnet/dotnet#46

No functional changes introduced.

[JanKrivanek]

Looks good - kust a minor comment on an accidental header removal

[ViktorHofer]

I assume the failures in this PR are unrelated?

[JanKrivanek]

I assume the failures in this PR are unrelated?

I do not recall seaing any similar error recently.
Reruning just for sure. Let's have closer look tomorrow if it's persistent

[JanKrivanek]

Still failing
Microsoft.NETCoreSdk.BundledVersions.props is missing for some reason

I'm short on time today - how urgent is this?

[ViktorHofer]

Not too urgent. Getting it in later this week is totally fine.

[JanKrivanek]

Hi @ViktorHofer - I believe the issue is directly related to the change

The missing Microsoft.NETCoreSdk.BundledVersions.props is imported in SourceBuildIntermediate.proj - that is not part of the failing build:

The reason will be likely related to the fact that the conditionaly excluded target (ConfigureInnerBuildArgs) prepares InnerBuildArgs property that is used later on in other targets. The property is now missing any project to run - so likely rest of the configuration that it's serving is lost that way:

I haven't dug deeper into what exactly is the purpose of the property and what is skipped as the result of missing project - but hopefully you are equiped to carry on investigation based on the intent of the change

[ViktorHofer]

Thank you for taking a look. This is really weird but let me try something different.

[AR-May]

LGTM