Shared EvaluationContext for graph construction #9680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dotnet#9678 by creating a single shared `EvaluationContext` in the `Graph` object and using it when creating `ProjectInstance`s using the default factory. This is similar to how NuGet static-graph restore already works: https://github.com/NuGet/NuGet.Client/blob/b83566ec2369c4e9fd07e6f95d734dfe370a1e66/src/NuGet.Core/NuGet.Build.Tasks.Console/MSBuildStaticGraphRestore.cs#L885 Since we're evaluating the projects in the graph in parallel and "all at once", the shared caches in the `EvaluationContext` should be a solid improvement.
dfederm
reviewed
Jan 24, 2024
dfederm
reviewed
Jan 24, 2024
dfederm
reviewed
Jan 24, 2024
dfederm
reviewed
Jan 24, 2024
dfederm
approved these changes
Jan 25, 2024
ladipro
approved these changes
Feb 6, 2024
rokonec
approved these changes
Feb 6, 2024
Do you remember what you were thinking of about VCProj? Was it for building the graph that part of the VS repo? If so this won't help: those scenarios already had good SDK resolution caching; it's the simple API calls like |
ladipro
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9678 by creating a single shared
EvaluationContextin theGraphobject and using it when creatingProjectInstances using the default factory.This is similar to how NuGet static-graph restore already works: https://github.com/NuGet/NuGet.Client/blob/b83566ec2369c4e9fd07e6f95d734dfe370a1e66/src/NuGet.Core/NuGet.Build.Tasks.Console/MSBuildStaticGraphRestore.cs#L885
Since we're evaluating the projects in the graph in parallel and "all at once", the shared caches in the
EvaluationContextshould be a solid improvement.