Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump some System.* deps to 8.0.0 #9705

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

rainersigwald
Copy link
Member

While looking at something else, I noticed that these references were stale.

(This should be automated but dependabot/dependabot-core#7206.)

While looking at something else, I noticed that these references were stale.
@rainersigwald rainersigwald requested a review from a team as a code owner February 1, 2024 22:52
@AraHaan
Copy link
Member

AraHaan commented Feb 2, 2024

At this point why not have the .NET github bot update these here as well?

Copy link
Member

@AraHaan AraHaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Also why not bump all of the System.* deps?)

@rainersigwald
Copy link
Member Author

At this point why not have the .NET github bot update these here as well?

There's no mechanism for "latest released version of this package" in the darc/maestro system. Since we need to depend on stable versions that match the ones in Visual Studio, we can't generally go to "the latest from a particular channel" like most of .NET can.

Also why not bump all of the System.* deps?

Did I miss something?

@rainersigwald rainersigwald requested a review from a team February 2, 2024 16:47
@AraHaan
Copy link
Member

AraHaan commented Feb 2, 2024

At this point why not have the .NET github bot update these here as well?

There's no mechanism for "latest released version of this package" in the darc/maestro system. Since we need to depend on stable versions that match the ones in Visual Studio, we can't generally go to "the latest from a particular channel" like most of .NET can.

Also why not bump all of the System.* deps?

Did I miss something?

  • System.Private.Uri
  • System.Runtime
  • System.Security.Cryptography.X509Certificates

Are among the ones I see. I think it should be safe to update these too if available.

@rainersigwald
Copy link
Member Author

At this point why not have the .NET github bot update these here as well?

There's no mechanism for "latest released version of this package" in the darc/maestro system. Since we need to depend on stable versions that match the ones in Visual Studio, we can't generally go to "the latest from a particular channel" like most of .NET can.

Also why not bump all of the System.* deps?

Did I miss something?

  • System.Private.Uri
  • System.Runtime
  • System.Security.Cryptography.X509Certificates

Are among the ones I see. I think it should be safe to update these too if available.

"if available" is the key phrase. Those all look like latest to me:

https://www.nuget.org/packages/System.Private.Uri#versions-body-tab
https://www.nuget.org/packages/System.Runtime#versions-body-tab
https://www.nuget.org/packages/System.Security.Cryptography.X509Certificates#versions-body-tab

@rainersigwald rainersigwald merged commit 001c067 into dotnet:main Feb 20, 2024
8 checks passed
@rainersigwald rainersigwald deleted the bump-system-refs branch February 20, 2024 19:43
maridematte pushed a commit to maridematte/msbuild that referenced this pull request Feb 26, 2024
I noticed that these references were stale.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants