Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove result indicator from test summary #9929

Merged
merged 8 commits into from
Apr 17, 2024
Merged

Remove result indicator from test summary #9929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
70321a6
Remove result indicator from test summary
nohwnd Mar 26, 2024
e89f2cb
Fix summary coloring
nohwnd Mar 26, 2024
49eafc9
Remove attachments
nohwnd Mar 26, 2024
45b2ca4
Move summary above build result, add separator
nohwnd Mar 27, 2024
988b4b7
Merge branch 'main' into remove-result-indicator-from-test-summary
nohwnd Mar 27, 2024
f87f274
Merge conflicts
nohwnd Apr 9, 2024
d60ade6
Fix tests
nohwnd Apr 15, 2024
858ea1e
Revert changes done by resx editor in VS
nohwnd Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...apshots/TerminalLogger_Tests.PrintTestSummaryNormalVerbosity_Succeeded.Linux.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
]9;4;3;\ project test succeeded (0.2s)
[?25l
[?25h
Test summary: total: 10, failed: 1, succeeded: 7, skipped: 2, duration: 1.0s
Build succeeded in 5.0s
Test run failed. Total: 10 Failed: 1 Passed: 7 Skipped: 2, Duration: 1.0s
]9;4;0;\
2 changes: 1 addition & 1 deletion ...Snapshots/TerminalLogger_Tests.PrintTestSummaryNormalVerbosity_Succeeded.OSX.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
 project test succeeded (0.2s)
[?25l
[?25h
Test summary: total: 10, failed: 1, succeeded: 7, skipped: 2, duration: 1.0s
Build succeeded in 5.0s
Test run failed. Total: 10 Failed: 1 Passed: 7 Skipped: 2, Duration: 1.0s
2 changes: 1 addition & 1 deletion ...shots/TerminalLogger_Tests.PrintTestSummaryNormalVerbosity_Succeeded.Windows.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
]9;4;3;\ project test succeeded (0.2s)
[?25l
[?25h
Test summary: total: 10, failed: 1, succeeded: 7, skipped: 2, duration: 1.0s
Build succeeded in 5.0s
Test run failed. Total: 10 Failed: 1 Passed: 7 Skipped: 2, Duration: 1.0s
]9;4;0;\
23 changes: 19 additions & 4 deletions src/MSBuild/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1641,10 +1641,25 @@
{4}: duration in seconds with 1 decimal point
</comment>
</data>
<data name="TestSummary" xml:space="preserve">
<value>Test run {0}. Total: {1} Failed: {2} Passed: {3} Skipped: {4}, Duration: {5}s</value>
<comment>{0} string, localized result e.g. Failed surrounded by ANSI colors.
{1-5} whole number</comment>
<data name="TestSummary_BannerAndTotal" xml:space="preserve">
<value>Test summary: total: {0}</value>
<comment>{0} whole number</comment>
</data>
<data name="TestSummary_Duration" xml:space="preserve">
<value>duration: {0}s</value>
<comment>{0} whole number</comment>
</data>
<data name="TestSummary_Failed" xml:space="preserve">
<value>failed: {0}</value>
<comment>{0} whole number</comment>
</data>
<data name="TestSummary_Skipped" xml:space="preserve">
<value>skipped: {0}</value>
<comment>{0} whole number</comment>
</data>
<data name="TestSummary_Succeeded" xml:space="preserve">
<value>succeeded: {0}</value>
<comment>{0} whole number</comment>
</data>
<!-- **** TerminalLogger strings end **** -->
nohwnd marked this conversation as resolved.
Show resolved Hide resolved
<!--
Expand Down
29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.cs.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.de.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.es.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.fr.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.it.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.ja.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.ko.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.pl.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 24 additions & 5 deletions src/MSBuild/Resources/xlf/Strings.pt-BR.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading