Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable localization vs17.9 #9937

Conversation

YuliiaKovalova
Copy link
Member

Disable localization vs17.9

@YuliiaKovalova YuliiaKovalova requested a review from a team as a code owner March 27, 2024 16:29
Copy link
Contributor

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

@rainersigwald
Copy link
Member

Is this necessary? I wouldn't expect it to ever actually do anything . . .

@YuliiaKovalova
Copy link
Member Author

Is this necessary? I wouldn't expect it to ever actually do anything . . .

Let's exclude it from checklist then :)
#9914

@rainersigwald
Copy link
Member

Oh to be clear I can definitely be misunderstanding things here, we should chase down whoever added that step and confirm!

@Forgind
Copy link
Member

Forgind commented Mar 27, 2024

It looks like @JanKrivanek included it in the template #8896 where it wasn't in the version prior.

@JanKrivanek
Copy link
Member

We localize main and latest release branch (that's the max we can have). Each branch is required to have a separate loc setup, which should not be invoked from a different branch (then we'd get conflicting PRs as we used to have some time back).

For this reason we need to disable the latest release branch localization requests on a new branch creation and issue loc ticket to request swap from (latest-1) to latest.

Alternatively we can localize main only - then we'd need to only disable the latest release branch loc requests (this PR) and we'd avoid the loc tickets. But we'd need to keep in mind to manually temporarily reroute localization on servicing involving resource files changes (as we already now should with older branches servicing - but that rarely happens)

@rainersigwald
Copy link
Member

Ok, given the cost of changes to servicing branches (having to bump the version manually) I don't love this--maybe we should invest in version bump automation.

@YuliiaKovalova YuliiaKovalova merged commit 610b4d3 into dotnet:vs17.9 Apr 2, 2024
8 checks passed
@JanKrivanek
Copy link
Member

Ok, given the cost of changes to servicing branches (having to bump the version manually) I don't love this--maybe we should invest in version bump automation.

#9960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants