Adjust tests with terminal logger enabled #9995
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9796
Context
With terminal logger enabled by
SET MSBUILDLIVELOGGER=auto
, current tests has the following problems.Message
is ignored by terminal logger currently and this causes tests depending on the message fail. Though Some way to opt specific messages into printing in TerminalLogger #9667 could get messages ptinted in terminal logger, it is a way to opt. To make messages output in console logger and terminal logger both, we need the workaround for printing messages in terminal logger. Affected tests: Microsoft.Build.Engine.UnitTests.MSBuildServer_Tests.MSBUILDLIVELOGGER
/MSBUILDTERMINALLOGGER
affects tests for these two environment variables. Affected tests: Microsoft.Build.UnitTests.TerminalLoggerConfiguration_Tests.TerminalLoggerOnByEnv.msbuild/src/MSBuild/XMake.cs
Lines 2854 to 2855 in bb7846e
In addition, cleaning up created TestEnvironment should revert variants in reverse order.
Changes Made
Message
, use the workaround adding --interactive for terminal logger to make messages output in console logger and terminal logger both.Testing
Run existing tests locally with setting the environment variable. Also verified in CI through #9957.
Notes