This repository has been archived by the owner on May 2, 2024. It is now read-only.
add arm64 build #131
Merged
add arm64 build #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManickaP
reviewed
Mar 3, 2023
src/System.Net.MsQuic.Transport/System.Net.MsQuic.Transport.csproj
Outdated
Show resolved
Hide resolved
src/System.Net.MsQuic.Transport/System.Net.MsQuic.Transport.csproj
Outdated
Show resolved
Hide resolved
hoyosjs
approved these changes
Mar 4, 2023
ManickaP
approved these changes
Mar 6, 2023
|
We do not have Windows ARM32 AFAIK @ManickaP. |
eerhardt
added a commit
to eerhardt/aspnetcore
that referenced
this pull request
Mar 7, 2023
The current version of msquic doesn't have win-arm64 binaries. See dotnet/msquic#131. Issues tracking re-enabling the test is dotnet#47065
eerhardt
added a commit
to dotnet/aspnetcore
that referenced
this pull request
Mar 7, 2023
* Skip HelixPlatform_QuickListenerIsSupported on win-arm64 The current version of msquic doesn't have win-arm64 binaries. See dotnet/msquic#131. Issues tracking re-enabling the test is #47065 * PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds arm64 windows binaries. I originally tried it as separate pipeline but that has two problems:
so instead this uses the existing hack for x86 when we simply build all three binaries unconditionally for Windows and we package them into Nuget in single step.
Since this repro is primarily used as transport I feel this is reasonable compromise.
if build by developers locally, it will require ARM targets in VS (probably already added to build runtime)
contributes to dotnet/runtime#82885