Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action to Node 20 #117

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Update action to Node 20 #117

merged 3 commits into from
Jan 25, 2024

Conversation

frankbuckley
Copy link
Contributor

Currently , a warning is reported when running the action:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: dotnet/nbgv@master. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

This PR updates the action to use Node 20.

It also includes some package updates. Notably, the switch to vercel/ncc was required to avoid error:0308010C:digital envelope routines::unsupported which I believe relates to OpenSSL v3.0 from Node 17 on.

I have tested the updated action and it executed as expected.

@frankbuckley
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AArnott AArnott added this pull request to the merge queue Jan 25, 2024
Merged via the queue into dotnet:master with commit f088059 Jan 25, 2024
3 checks passed
@frankbuckley frankbuckley deleted the dev/node20 branch January 25, 2024 19:36
@timheuer
Copy link
Member

@AArnott will you be publishing a new version to marketplace with this fix? 0.4.1 still shows warning

@AArnott
Copy link
Collaborator

AArnott commented Jan 27, 2024

Yes. You beat me to it, but I appreciate the reminder. v0.4.2 has the fix. But if your yaml consumes v0.4 (the branch) you'll get such fixes in the future automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants