Skip to content

Commit

Permalink
Remove unnecessary IServiceProvider registration (#2749)
Browse files Browse the repository at this point in the history
Was causing a "Circular Reference" error with Autofac (#2747) and potentially other containers
  • Loading branch information
Maarten88 authored and jdom committed Feb 21, 2017
1 parent e5f9d9a commit d65f65f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/Orleans/Runtime/OutsideRuntimeClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ public OutsideRuntimeClient(ClientConfiguration cfg, bool secondary = false)

var services = new ServiceCollection();
services.AddSingleton(cfg);
services.AddSingleton<IServiceProvider>(sp => sp);
services.AddSingleton<TypeMetadataCache>();
services.AddSingleton<AssemblyProcessor>();
services.AddSingleton(this);
Expand Down
1 change: 0 additions & 1 deletion src/OrleansRuntime/Silo/Silo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ internal Silo(SiloInitializationParameters initializationParams)

// Register system services.
var services = new ServiceCollection();
services.AddSingleton(sp => sp);
services.AddSingleton(this);
services.AddSingleton(initializationParams);
services.AddSingleton<ILocalSiloDetails>(initializationParams);
Expand Down

0 comments on commit d65f65f

Please sign in to comment.