Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FrozenDictionary to collections tests #2905

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

stephentoub
Copy link
Member

No description provided.

@stephentoub
Copy link
Member Author

Is there something I need to do to get the build to use preview nuget packages? These APIs are in System.Collections.Immutable.dll, which ships downlevel, but it appears to be using officially supported packages and thus can't find the APIs downlevel.

@cincuranet
Copy link
Contributor

Where is the preview package? Could the feed be added to this https://github.com/dotnet/performance/blob/main/NuGet.config?

@stephentoub
Copy link
Member Author

If nothing else, at this point the .NET 8 Preview 1 package is available on nuget.
https://www.nuget.org/packages/System.Collections.Immutable/8.0.0-preview.1.23110.8

@cincuranet
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cincuranet
Copy link
Contributor

I'll check why net462 and nativeaot7.0 are complaining. Rest is green as grass.

@cincuranet
Copy link
Contributor

cincuranet commented Feb 23, 2023

Hmm, for the nativeaot7.0 ilc takes it's own packages\runtime.win-x64.microsoft.dotnet.ilcompiler\7.0.3\framework\System.Collections.Immutable.dll. Not sure how to force it to use the one from NuGet. Any ideas?

cc @MichalStrehovsky

@MichalStrehovsky
Copy link
Member

Not sure how to force it to use the one from NuGet. Any ideas?

I don't know of a way short of hacking MSBuild targets. We track this in dotnet/runtime#67080.

Can this be limited to testing with 8.0 NativeAOT?

@cincuranet
Copy link
Contributor

Can this be limited to testing with 8.0 NativeAOT?

Checking...

@cincuranet cincuranet self-assigned this Feb 28, 2023
@cincuranet cincuranet force-pushed the frozencollections branch 3 times, most recently from 5da8cc9 to d507be9 Compare March 21, 2023 17:56
@cincuranet
Copy link
Contributor

Finally all the stars aligned and it's green (Blazor failure is unrelated). Merging.

@cincuranet cincuranet merged commit 7c7f326 into dotnet:main Mar 22, 2023
@stephentoub stephentoub deleted the frozencollections branch March 22, 2023 11:17
@stephentoub
Copy link
Member Author

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants