upgrade real-world to net9

[kunalspathak]

No description provided.

[LoopedBard3]

LGTM if the test run failures match main or there are no failures.

[cincuranet]

@kunalspathak Do you want me to merge it?

[kunalspathak]

@kunalspathak Do you want me to merge it?

sure, once CI is green.

[cincuranet]

illink is failing with:

[2023/11/27 19:03:13][INFO] System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
[2023/11/27 19:03:13][INFO]  ---> System.ApplicationException: Failed to publish trimmed sample application:
[2023/11/27 19:03:13][INFO]  >> MSBuild version 17.9.0-preview-23574-01+7b37a280a for .NET
[2023/11/27 19:03:13][INFO]  >>   Determining projects to restore...
[2023/11/27 19:03:13][INFO]  >>   Restored /datadisks/disk1/work/B3080983/w/B4A90989/e/artifacts/bin/ILLinkBenchmarks/Release/net9.0/SampleProject/HelloWorld.csproj (in 2.3 sec).
[2023/11/27 19:03:13][INFO]  >> /datadisks/disk1/work/B3080983/w/B4A90989/e/tools/dotnet/x64/sdk/9.0.100-alpha.1.23577.6/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.CrossTargeting.targets(31,5): error NETSDK1129: The 'Publish' target is not supported without specifying a target framework. The current project targets multiple frameworks, you must specify one of the following frameworks in order to publish: net9.0 [/datadisks/disk1/work/B3080983/w/B4A90989/e/artifacts/bin/ILLinkBenchmarks/Release/net9.0/SampleProject/HelloWorld.csproj]
[2023/11/27 19:03:13][INFO]  >>
[2023/11/27 19:03:13][INFO] 
[2023/11/27 19:03:13][INFO]    at ILLinkBenchmarks.Utilities.PublishSampleProject(String projectFilePath, String[] extraArgs) in /datadisks/disk1/work/B3080983/w/B4A90989/e/src/benchmarks/real-world/ILLink/Utilities.cs:line 71
[2023/11/27 19:03:13][INFO]    at ILLinkBenchmarks.BasicBenchmark.LinkHelloWorldGlobalSetup() in /datadisks/disk1/work/B3080983/w/B4A90989/e/src/benchmarks/real-world/ILLink/BasicBenchmark.cs:line 43
[2023/11/27 19:03:13][INFO]    at BenchmarkDotNet.Engines.EngineFactory.CreateReadyToRun(EngineParameters engineParameters)
[2023/11/27 19:03:13][INFO]    at BenchmarkDotNet.Autogenerated.Runnable_0.Run(IHost host, String benchmarkName) in /datadisks/disk1/work/B3080983/w/B4A90989/e/artifacts/bin/ILLinkBenchmarks/Release/net9.0/3608cf8b-15c8-4123-90f9-f33e75f1d395/3608cf8b-15c8-4123-90f9-f33e75f1d395.notcs:line 182
[2023/11/27 19:03:13][INFO]    at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
[2023/11/27 19:03:13][INFO]    at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
[2023/11/27 19:03:13][INFO]    --- End of inner exception stack trace ---
[2023/11/27 19:03:13][INFO]    at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
[2023/11/27 19:03:13][INFO]    at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[2023/11/27 19:03:13][INFO]    at BenchmarkDotNet.Autogenerated.UniqueProgramName.AfterAssemblyLoadingAttached(String[] args) in /datadisks/disk1/work/B3080983/w/B4A90989/e/artifacts/bin/ILLinkBenchmarks/Release/net9.0/3608cf8b-15c8-4123-90f9-f33e75f1d395/3608cf8b-15c8-4123-90f9-f33e75f1d395.notcs:line 57

Do we want to hold off the PR or merge and investigate then? I'll check eurotomorrow either way.

Rest is known.

[LoopedBard3]

Do we want to hold off the PR or merge and investigate then? I'll check eurotomorrow either way.

I think we wait until we have had a chance to look into it a little bit, making a decision to merge with the break or not then.

[kunalspathak]

illink is failing with:

It was failing because of the change suggested in #3511 (comment). I reverted it and things work locally.

[LoopedBard3]

Sorry, wrong GitHub button.

[LoopedBard3]

The change seems to be caused by the change from TargetFramework to TargetFrameworks in the Illink Sample csproj here: https://github.com/dotnet/performance/pull/3511/files#diff-359fe5c6a7aea7d51cba906e3885f24452af66155f3d0568a4b7d13297278b68L4-R5.

Something like this update to the publish args in the Utilities.cs -> PublishSampleProject (https://github.com/dotnet/performance/blob/main/src/benchmarks/real-world/ILLink/Utilities.cs#L64) fixed the test locally for me.

-f {Environment.GetEnvironmentVariable("PERFLAB_TARGET_FRAMEWORKS") ?? "net9.0"}

[LoopedBard3]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kunalspathak]

Are the CI failures known and can we merge the PR?

[cincuranet]

Yes, these failures are known. I'm waiting for @LoopedBard3's response, whether he'll include his fix here or create separate PR.

[LoopedBard3]

I will go ahead and make another PR once this one goes in 👍. @cincuranet I think we are good to merge this.