Use correct python executable inside venv for perf tests on Windows #4339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
LoopedBard3
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using
py -3to run python on Windows machines, however after we activated the python venv, the python executable is justpython. We had a few machines that had some corrupt or broken global python installs (#4242) and so jobs were failing on them, with this change we will now be properly isolated from issues with the global python installation.In addition, I also added an extra command after venv activation to re-enable
echo. For some reason the venv activation script turnsechooff and then doesn't re-enable it at the end, so with this change we can now see all the commands that are run inside the venv on Windows.