Solution with 56 projects is unsable once migrated to csproj.

[NTaylorMullen]

Every major operation (opening/restoring, building, etc.) takes several minutes to complete, usually resulting in the "not responding" dialog over and over. As a disclaimer the project does take more time than average project to restore but it should not repeatedly dive into the "not responding" state or take as long as it currently does. Doing these operations at the command line is significantly faster.

This branch of MVC demonstrates the issue quite well. Note, it used to work decently fine with the xproj system.

The VS I'm using:

[NTaylorMullen]

Updated issue with additional info.

[mavasani]

Open solution

I tried opening the solution on D15PreRel 26130 and it takes:

1. Slightly less than 60 seconds to fully load the solution in a new VS instance.
2. Closing and re-opening the solution in the same VS instance takes roughly 35-40 seconds to load.

IMO, these seem like pretty reasonable load times for a 50+ project solution. Did you see something different @NTaylorMullen ?
Only VS component that takes up significant amount of time (20%-30%) is microsoft.visualstudio.projectsystem.implementation!PropertyPagesCatalogLoader.CreatePropertyCatalogsAsync, we can ask CPS folks to look if that can be optimized.

Build/Restore

I am unable to restore the solution from command line or VS (build.cmd fails). Migration fails for one of the projects, which is probably the cause of this:

Microsoft.AspNetCore.Mvc.FunctionalTests

Message

test\Microsoft.AspNetCore.Mvc.FunctionalTests\Microsoft.AspNetCore.Mvc.FunctionalTests.xproj: Failed to migrate XProj project Microsoft.AspNetCore.Mvc.FunctionalTests. 'dotnet migrate --skip-backup -s -x "c:\Mvc\test\Microsoft.AspNetCore.Mvc.FunctionalTests\Microsoft.AspNetCore.Mvc.FunctionalTests.xproj" "c:\Mvc\test\Microsoft.AspNetCore.Mvc.FunctionalTests" -r "C:\Users\mavasani\AppData\Local\Temp\f4cmfz05.xwr" --format-report-file-json' exited with error code 1.

test\Microsoft.AspNetCore.Mvc.FunctionalTests\Microsoft.AspNetCore.Mvc.FunctionalTests.xproj: MIGRATE1014::Unresolved Dependency: Unresolved project dependency (MvcSandbox)

Can you try to open/migrate/build your solution on latest d15prerel? Additionally, if you can collect the perfview ETL traces for the scenarios where you get the UI hang, that would help investigations going quicker:

1. Download PerfView from https://www.microsoft.com/en-us/download/details.aspx?id=28567
2. Start VS and execute your scenario till you see the high CPU usage.
3. In PerfView, click Collect -> Collect -> Start Collection (note the location where the trace is collected)
4. Wait for few seconds for the trace collection
5. Stop Collection in PerfView
6. Share the ETL trace generated by PerfView - Let me know once you have a trace and I can provide you a onedrive link to upload it or you can put it on an internal share.

[mavasani]

Restore in VS generates this error:

Error occurred while restoring NuGet packages: The operation failed as details for project Microsoft.AspNetCore.Mvc.RazorPages.Test could not be loaded.

[Eilon]

@mavasani you mention that migration failed, but this solution is already 100% CSPROJ. Which migration was it?

[NTaylorMullen]

@mavasani ensure you checkout the nimullen/migration.badvs branch I mentioned in the issue and then open the Mvc.sln. I had to manually migrate a lot of MVC due to its complexity/known bugs in dotnet migrate.

[mavasani]

Yes, I did that and the build succeeded. Thanks, investigating further.

[mavasani]

Alright, so I got a VS hang when attempting to open the solution from your branch. The hang is coming from PropertyBrowser forcing certain property to be computed on the UI thread:

 	mscorlib.dll!System.Threading.Monitor.Wait(object obj, int millisecondsTimeout, bool exitContext)	Unknown
 	mscorlib.dll!System.Threading.Monitor.Wait(object obj, int millisecondsTimeout)	Unknown
 	mscorlib.dll!System.Threading.ManualResetEventSlim.Wait(int millisecondsTimeout, System.Threading.CancellationToken cancellationToken)	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.SpinThenBlockingWait(int millisecondsTimeout, System.Threading.CancellationToken cancellationToken)	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.InternalWait(int millisecondsTimeout, System.Threading.CancellationToken cancellationToken)	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.Wait(int millisecondsTimeout, System.Threading.CancellationToken cancellationToken)	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.Wait(System.TimeSpan timeout)	Unknown
 	Microsoft.VisualStudio.Threading.dll!Microsoft.VisualStudio.Threading.JoinableTaskFactory.WaitSynchronouslyCore(System.Threading.Tasks.Task task)	Unknown
 	Microsoft.VisualStudio.Threading.dll!Microsoft.VisualStudio.Threading.JoinableTaskFactory.WaitSynchronously(System.Threading.Tasks.Task task)	Unknown
 	Microsoft.VisualStudio.Threading.dll!Microsoft.VisualStudio.Threading.JoinableTask.CompleteOnCurrentThread()	Unknown
 	Microsoft.VisualStudio.Threading.dll!Microsoft.VisualStudio.Threading.JoinableTask<Microsoft.VisualStudio.ProjectSystem.VS.Implementation.PropertyPages.DynamicType>.CompleteOnCurrentThread()	Unknown
 	Microsoft.VisualStudio.Threading.dll!Microsoft.VisualStudio.Threading.JoinableTaskFactory.Run<Microsoft.VisualStudio.ProjectSystem.VS.Implementation.PropertyPages.DynamicType>(System.Func<System.Threading.Tasks.Task<Microsoft.VisualStudio.ProjectSystem.VS.Implementation.PropertyPages.DynamicType>> asyncMethod, Microsoft.VisualStudio.Threading.JoinableTaskCreationOptions creationOptions)	Unknown
 	Microsoft.VisualStudio.Threading.dll!Microsoft.VisualStudio.Threading.JoinableTaskFactory.Run<Microsoft.VisualStudio.ProjectSystem.VS.Implementation.PropertyPages.DynamicType>(System.Func<System.Threading.Tasks.Task<Microsoft.VisualStudio.ProjectSystem.VS.Implementation.PropertyPages.DynamicType>> asyncMethod)	Unknown
 	Microsoft.VisualStudio.ProjectSystem.Implementation.dll!Microsoft.VisualStudio.ProjectSystem.ProjectMultiThreadedService.ExecuteSynchronously<Microsoft.VisualStudio.ProjectSystem.VS.Implementation.PropertyPages.DynamicType>(System.Func<System.Threading.Tasks.Task<Microsoft.VisualStudio.ProjectSystem.VS.Implementation.PropertyPages.DynamicType>> asyncAction)	Unknown
 	Microsoft.VisualStudio.ProjectSystem.VS.Implementation.dll!Microsoft.VisualStudio.ProjectSystem.VS.Implementation.PropertyPages.DynamicTypeBrowseObjectBase.InnerDynamicType.get()	Unknown
 	Microsoft.VisualStudio.ProjectSystem.VS.Implementation.dll!Microsoft.VisualStudio.ProjectSystem.VS.Implementation.PropertyPages.DynamicTypeBrowseObjectBase.System.ComponentModel.ICustomTypeDescriptor.GetComponentName()	Unknown
 	System.dll!System.ComponentModel.TypeDescriptor.MergedTypeDescriptor.System.ComponentModel.ICustomTypeDescriptor.GetComponentName()	Unknown
 	System.dll!System.ComponentModel.ReflectTypeDescriptionProvider.GetFullComponentName(object component)	Unknown
 	System.dll!System.ComponentModel.TypeDescriptor.TypeDescriptionNode.GetFullComponentName(object component)	Unknown
 	System.dll!System.ComponentModel.DelegatingTypeDescriptionProvider.GetFullComponentName(object component)	Unknown
 	System.dll!System.ComponentModel.TypeDescriptor.TypeDescriptionNode.GetFullComponentName(object component)	Unknown
 	System.dll!System.ComponentModel.TypeDescriptor.GetFullComponentName(object component)	Unknown
 	Microsoft.VisualStudio.dll!Microsoft.VisualStudio.PropertyBrowser.CBEntry.Name.get()	Unknown
 	Microsoft.VisualStudio.dll!Microsoft.VisualStudio.PropertyBrowser.CBEntry.ToString()	Unknown
 	mscorlib.dll!System.Convert.ToString(object value, System.IFormatProvider provider)	Unknown
 	System.Windows.Forms.dll!System.Windows.Forms.ListControl.GetItemText(object item)	Unknown
 	System.Windows.Forms.dll!System.Windows.Forms.ComboBox.NativeInsert(int index, object item)	Unknown
 	System.Windows.Forms.dll!System.Windows.Forms.ComboBox.ObjectCollection.AddInternal(object item)	Unknown
 	System.Windows.Forms.dll!System.Windows.Forms.ComboBox.ObjectCollection.AddRangeInternal(System.Collections.IList items)	Unknown
 	System.Windows.Forms.dll!System.Windows.Forms.ComboBox.ObjectCollection.AddRange(object[] items)	Unknown
 	Microsoft.VisualStudio.dll!Microsoft.VisualStudio.PropertyBrowser.PropertyBrowser.UpdateComponentsCombobox(bool updateComboBox)	Unknown
 	Microsoft.VisualStudio.dll!Microsoft.VisualStudio.PropertyBrowser.PropertyBrowser.UpdateSelection(bool updateGrid, bool updateComboBox)	Unknown
 	Microsoft.VisualStudio.dll!Microsoft.VisualStudio.PropertyBrowser.PropertyBrowser.OnIdle(object sender, System.EventArgs e)	Unknown

It doesn't repro if I keep the property browser closed during solution load, and the solution loads in under a minute.

However, once the solution load completes, there are a few successive UI hangs, where MSBuild is taking up most of the CPU and even spiked to 1 Gig of RAM. These are due to the Test Window issue, bug 366684

 	Microsoft.VisualStudio.Threading.dll!Microsoft.VisualStudio.Threading.NoMessagePumpSyncContext.Wait(System.IntPtr[] waitHandles, bool waitAll, int millisecondsTimeout)	Unknown
 	mscorlib.dll!System.Threading.SynchronizationContext.InvokeWaitMethodHelper(System.Threading.SynchronizationContext syncContext, System.IntPtr[] waitHandles, bool waitAll, int millisecondsTimeout)	Unknown
 	[Native to Managed Transition]	
 	mscorlib.ni.dll!728aa507()	Unknown
 	[Managed to Native Transition]	
 	mscorlib.dll!System.Threading.Monitor.Wait(object obj, int millisecondsTimeout, bool exitContext)	Unknown
 	mscorlib.dll!System.Threading.Monitor.Wait(object obj, int millisecondsTimeout)	Unknown
 	mscorlib.dll!System.Threading.ManualResetEventSlim.Wait(int millisecondsTimeout, System.Threading.CancellationToken cancellationToken)	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.SpinThenBlockingWait(int millisecondsTimeout, System.Threading.CancellationToken cancellationToken)	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.InternalWait(int millisecondsTimeout, System.Threading.CancellationToken cancellationToken)	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.Wait(int millisecondsTimeout, System.Threading.CancellationToken cancellationToken)	Unknown
 	mscorlib.dll!System.Threading.Tasks.Task.Wait(System.TimeSpan timeout)	Unknown
 	Microsoft.VisualStudio.Threading.dll!Microsoft.VisualStudio.Threading.JoinableTaskFactory.WaitSynchronouslyCore(System.Threading.Tasks.Task task)	Unknown
 	Microsoft.VisualStudio.Threading.dll!Microsoft.VisualStudio.Threading.JoinableTaskFactory.WaitSynchronously(System.Threading.Tasks.Task task)	Unknown
 	Microsoft.VisualStudio.Threading.dll!Microsoft.VisualStudio.Threading.JoinableTask.CompleteOnCurrentThread()	Unknown
 	Microsoft.VisualStudio.Threading.dll!Microsoft.VisualStudio.Threading.JoinableTask<Microsoft.VisualStudio.ProjectSystem.VS.HResult>.CompleteOnCurrentThread()	Unknown
 	Microsoft.VisualStudio.Threading.dll!Microsoft.VisualStudio.Threading.JoinableTaskFactory.Run<Microsoft.VisualStudio.ProjectSystem.VS.HResult>(System.Func<System.Threading.Tasks.Task<Microsoft.VisualStudio.ProjectSystem.VS.HResult>> asyncMethod, Microsoft.VisualStudio.Threading.JoinableTaskCreationOptions creationOptions)	Unknown
 	Microsoft.VisualStudio.ProjectSystem.Implementation.dll!Microsoft.VisualStudio.ProjectSystem.ProjectMultiThreadedService.ExecuteSynchronously<Microsoft.VisualStudio.ProjectSystem.VS.HResult>(System.Func<System.Threading.Tasks.Task<Microsoft.VisualStudio.ProjectSystem.VS.HResult>> asyncAction)	Unknown
 	Microsoft.VisualStudio.ProjectSystem.VS.Implementation.dll!Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.ProjectNode.HrInvoke.AnonymousMethod__0()	Unknown
 	Microsoft.VisualStudio.ProjectSystem.VS.dll!Microsoft.VisualStudio.ProjectSystem.VS.HResult.Invoke(System.Func<Microsoft.VisualStudio.ProjectSystem.VS.HResult> action, System.IServiceProvider vsShellServiceProvider, Microsoft.VisualStudio.ProjectSystem.IProjectFaultHandlerService projectFaultHandlerService, Microsoft.VisualStudio.ProjectSystem.UnconfiguredProject project)	Unknown
 	Microsoft.VisualStudio.ProjectSystem.VS.Implementation.dll!Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.ProjectNode.HrInvoke(System.Func<System.Threading.Tasks.Task<Microsoft.VisualStudio.ProjectSystem.VS.HResult>> asyncAction, bool registerProjectFaultHandlerService)	Unknown
 	Microsoft.VisualStudio.ProjectSystem.VS.Implementation.dll!Microsoft.VisualStudio.ProjectSystem.VS.Implementation.Package.ProjectConfig.OpenOutputGroup(string projectOutputGroupName, out Microsoft.VisualStudio.Shell.Interop.IVsOutputGroup ppIVsOutputGroupParam)	Unknown
 	Microsoft.VisualStudio.TestWindow.Core.dll!Microsoft.VisualStudio.TestWindow.VSProjectExtensions.GetProjectOutputPath(Microsoft.VisualStudio.Shell.Interop.IVsProjectCfg2 projectConfig, string groupName, Microsoft.VisualStudio.TestWindow.Extensibility.ILogger logger)	Unknown
 	Microsoft.VisualStudio.TestWindow.Core.dll!Microsoft.VisualStudio.TestWindow.VSProjectExtensions.GetKeyOutputForGroup(Microsoft.VisualStudio.Shell.Interop.IVsSolutionBuildManager buildManager, Microsoft.VisualStudio.Shell.Interop.IVsProject project, string groupName, Microsoft.VisualStudio.TestWindow.Extensibility.ILogger logger)	Unknown
 	Microsoft.VisualStudio.TestWindow.Core.dll!Microsoft.VisualStudio.TestWindow.VSProjectExtensions.GetProjectOutputPath(Microsoft.VisualStudio.Shell.Interop.IVsSolutionBuildManager buildManager, Microsoft.VisualStudio.Shell.Interop.IVsProject project, Microsoft.VisualStudio.TestWindow.Extensibility.ILogger logger)	Unknown
 	Microsoft.VisualStudio.TestWindow.Core.dll!Microsoft.VisualStudio.TestWindow.VSProjectExtensions.GetProjectOutputPath(Microsoft.VisualStudio.Shell.Interop.IVsProject project, System.IServiceProvider serviceProvider, Microsoft.VisualStudio.TestWindow.Controller.SafeDispatcher safeDispatcher, Microsoft.VisualStudio.TestWindow.Extensibility.ILogger logger)	Unknown
 	Microsoft.VisualStudio.TestWindow.Core.dll!Microsoft.VisualStudio.TestWindow.VsAdapters.VsTestContainer.Source.get()	Unknown
 	Microsoft.VisualStudio.TestWindow.Core.dll!Microsoft.VisualStudio.TestWindow.VsAdapters.VsTestContainer.CreateTimeStamp(bool deviceSelectionChanged)	Unknown
 	Microsoft.VisualStudio.TestWindow.Core.dll!Microsoft.VisualStudio.TestWindow.VsAdapters.VsTestContainer.VsTestContainer(Microsoft.VisualStudio.TestWindow.Extensibility.ITestContainerDiscoverer discoverer, Microsoft.VisualStudio.TestWindow.Controller.SafeDispatcher safeDispatcher, Microsoft.VisualStudio.TestWindow.Extensibility.ILogger log, Microsoft.VisualStudio.Shell.Interop.IVsProject project, System.IServiceProvider serviceProvider, System.Collections.Generic.IEnumerable<System.Lazy<Microsoft.VisualStudio.TestWindow.VsAdapters.IVsAppContainerUtilities, Microsoft.VisualStudio.TestWindow.VsAdapters.INamedMetadata>> appContainerUtilities)	Unknown
 	Microsoft.VisualStudio.TestWindow.Core.dll!Microsoft.VisualStudio.TestWindow.VsAdapters.VsProjectOutputContainerDiscoverer.get_TestContainers.AnonymousMethod__12_0(Microsoft.VisualStudio.Shell.Interop.IVsProject p)	Unknown
 	System.Core.dll!System.Linq.Enumerable.WhereSelectEnumerableIterator<Microsoft.VisualStudio.Shell.Interop.IVsProject, Microsoft.VisualStudio.TestWindow.VsAdapters.VsTestContainer>.MoveNext()	Unknown
 	System.Core.dll!System.Linq.Enumerable.WhereEnumerableIterator<Microsoft.VisualStudio.TestWindow.VsAdapters.VsTestContainer>.MoveNext()	Unknown
 	mscorlib.dll!System.Collections.Generic.List<Microsoft.VisualStudio.TestWindow.Extensibility.ITestContainer>.List(System.Collections.Generic.IEnumerable<Microsoft.VisualStudio.TestWindow.Extensibility.ITestContainer> collection)	Unknown
Microsoft.VisualStudio.Threading.JoinableTask<Microsoft.VisualStudio.ProjectSystem.VS.HResult>.CompleteOnCurrentThread()	Unknown
 	Microsoft.VisualStudio.Threading.dll!Microsoft.VisualStudio.Threading.JoinableTaskFactory.Run<Microsoft.VisualStudio.ProjectSystem.VS.HResult>(System.Func<System.Threading.Tasks.Task<Microsoft.VisualStudio.ProjectSystem.VS.HResult>> 

I am unable to repro any UI hang during solution build - I was able to open/edit files just fine during build. I'll keep playing with the solution a bit more.

[Eilon]

I just tried using Dev15 15.0.26129.0 D15REL (the build that JoC just asked everyone to install) and though it didn't quite take 15 minute to open, it was probably around 10 minutes (on my laptop), and VS was super slow for quite a while even after it opened.

[NTaylorMullen]

@mavasani the issue you linked accurately depicts all the perf issues the Mvc solution is running into within the Repro Steps section.

As for solution build not hanging on your end. Should I try and update my VS or download a different skew? It's pretty consistent for me.

[mavasani]

@NTaylorMullen @Eilon can you please share ETL traces for the hangs (my alias is mavasani)? Note that I did a clean install of the d15prerel 26130.00 and the only hangs I see were the couple mentioned above (PropertyBrowser and Test Window). I have tried closing/re-opening/build solution and opening and editing source files, and those seem to work fine.

@lifengl @srivatsn is the property browser issue known?

[Eilon]

Hmm, odd, when I try it again now I'm not seeing the same perf issues as before. It's still a bit slow to load, but you'd expect some slowness with this many projects. But I'm not seeing the 10-15min issue...

[lifengl]

I saw some hang when you load a large project with the property sheet window open couple month ago. That is largely because we show some project properties coming from design time build (like assembly version...) Not sure whether it is still the case. Making some of those properties hidden will prevent this problem. @jinujoseph, did we make the change into the product?.

[lifengl]

Also, connected service team fixed one performance problem last Friday, which impacts solution load time, and @BillHiebert is working a fix for an issue inside .Net Core Web project. If your solution contains any web project, it might be related.

[NTaylorMullen]

@lifengl Mvc contains many web projects so that could definitely be a factor.

[mavasani]

@NTaylorMullen @Eilon were you able to get any perf traces for the UI delays that we can investigate? Summarizing the current set of identified issues:

1. PropertyBrowser UI delay on open solution (intermittent): @jinujoseph is working on a fix. Jinu, do you have a tracking bug?
2. Connected service team issue, impacting solution load for web projects.
3. Test Window UI delay on open solution, and intermittently even while attempting to open/edit source files: Tracked by 366684. Note the update I made to that bug today - On the latest VS builds, I am not seeing other UI delays mentioned in its repro steps, except the ones from Test Window.

[NTaylorMullen]

@mavasani I haven't been able to yet. Upgraded my VS and things seem to be broken. Trying to get back to a state where I can gather that info.

[NTaylorMullen]

@mavasani after updating VS (d15rel) every sln I now open results in: Error occurred while restoring NuGet packages: The operation failed as details for project SomeProjectName could not be loaded. Upon unloading that project the error then moves to the next project.

I've tried workarounds mentioned here but no luck.

[NTaylorMullen]

Found the cause of my issue mentioned above: NuGet/Home#4496. Working on getting ETL traces for an already restored project.

[NTaylorMullen]

Got a few ETL traces. Opening MVC after it already being restored took nearly 10 minutes, here's the ETL: ‪\NTaylorMullen\SHARED\ETLVS\MvcOnOpen.etl.zip

Next I tried building MVC, It's still going with progress bar not even half way so I stopped it at almost the 25 min mark, here's the ETL: ‪\NTaylorMullen\SHARED\ETLVS\MvcBuild.zip

For both of these experiments I had the following windows focused:

• Test Explorer
• Output
• Solution Explorer

For all these tests there were significant VS not responding hangs.

I was using the optimized (less package refs, build bits etc.) nimullen/migration branch.

[mavasani]

@NTaylorMullen I see TestWindow and CPS design time builds on your trace, most of the time devenv is blocked on msbuild. I'll forward you instructions to patch your machine with TestWindow fix, and you can give it a try again and share new traces?

[NTaylorMullen]

@mavasani sounds good.

[mavasani]

For the build scenario, I see that almost 90% of time is spent in trying to write to the output window Microsoft.VisualStudio.ProjectSystem.VS.Implementation.VsOutputWindowTextWriterFactory+OutputWindowTextWriter+OutputStringAndCompletion.WriteToOutput:

Name                                                                                                                                                                                                                                                                                                                                                 	Inc %	      Inc	Exc %	    Exc
kernelbase!lstrlenW                                                                                                                                                                                                                                                                                                                                 	89.3	  614,924	89.3	614,924
+ msenv!VsUtil::CString::Append                                                                                                                                                                                                                                                                                                                      	89.3	  614,906	 0.0	      0
|+ msenv!VsUtil::CString::Append                                                                                                                                                                                                                                                                                                                     	89.3	  614,786	 0.0	      0
||+ msenv!CSUIBuilder::WriteBufferedOutputString                                                                                                                                                                                                                                                                                                     	89.3	  614,786	 0.0	      0
|| + msenv!CSUIBuilder::FBufferedOutputString                                                                                                                                                                                                                                                                                                        	89.3	  614,786	 0.0	      0
||  + msenv!CSUIBuilder::OutputStringNoPump                                                                                                                                                                                                                                                                                                          	89.3	  614,786	 0.0	      0
||   + microsoft.visualstudio.projectsystem.vs.implementation!dynamicClass.IL_STUB_CLRtoCOM(class System.String)                                                                                                                                                                                                                                     	89.3	  614,786	 0.0	      0
||    + microsoft.visualstudio.projectsystem.vs.implementation!Utilities.OutputStringTryNoPump                                                                                                                                                                                                                                                       	89.3	  614,786	 0.0	      0
||     + microsoft.visualstudio.projectsystem.vs.implementation!Microsoft.VisualStudio.ProjectSystem.VS.Implementation.VsOutputWindowTextWriterFactory+OutputWindowTextWriter+OutputStringAndCompletion.WriteToOutput(class Microsoft.VisualStudio.Shell.Interop.IVsOutputWindowPane3,class Microsoft.VisualStudio.Shell.Interop.IVsOutputWindowPane)	89.3	  614,786	 0.0	      0
||      + microsoft.visualstudio.projectsystem.vs.implementation!Microsoft.VisualStudio.ProjectSystem.VS.Implementation.VsOutputWindowTextWriterFactory+OutputWindowTextWriter+<>c__DisplayClass31_0+<<StartWriteOuputUnderPriority>b__0>d.MoveNext()                                                                                                	89.3	  614,786	 0.0	      0

@lifengl @jviau Can CPS investigate this?

[NTaylorMullen]

@mavasani I do have diagnostics on. That could be the reason for that.

[mavasani]

@NTaylorMullen Thanks for the traces. The Reload.etl.zip VS deadlock on reload/close solution is a dupe of dotnet/roslyn#14479. I see that the UI thread is stuck on microsoft.visualstudio.languageservices.implementation!CPSProject.Disconnect, which is at the bottom of the call stack in dotnet/roslyn#14479 (comment).

This was fixed by @dpoeschl couple of days ago, so hopefully won't be part of the next build with Roslyn insertion. David, do we know what build has your deadlock fix?

[mavasani]

@NTaylorMullen @Eilon - let me summarize the current findings again:

1. Open solution works reasonsable fine now, modulo the Test Window fix for VSO 366684 - this is currently being prepped for Escrow.
2. Close/Reload solution deadlock: I have hit this multiple times myself and this Roslyn fix should address it.
3. Build with diagnostic logging: You have a workaround and the underlying issue is tracked by [Performance] Visual Studio locks up after a build if you have diagnostic build turned on #1242.

Let me know if there is anything else that I have missed out and needs investigation. Otherwise, I'll keep this as a tracking bug to verify once the fixes for 1. and 2. above have been verified on an official build.

[dpoeschl]

@mavasani I just tested with d15rerl 26205.0 today and I couldn't repro the deadlock.

[mavasani]

Thanks, I'll test the MVC solution on the same build. @NTaylorMullen, please let us know if you get a deadlock on this build.

[mavasani]

I verified the deadlock on close solution doesn't repro for the MVC solution on 26205.0 and even Open solution is fine after applying the final Test Window private bits.

[mavasani]

@NTaylorMullen @Eilon - I am going to close this issue now, unless you have any further repros/traces for us to investigate.

[NTaylorMullen]

@mavasani Any idea when d15rel will be at a state that has all of the fixes that make using the Mvc.sln possible?

[mavasani]

@srivatsn Do we know when the Test Window fix is going in? We can update this issue once we have a build with the Test Window fix.

[srivatsn]

Likely tomorrow.

[jac009]

@NTaylorMullen later this week.

[NTaylorMullen]

I'm testing out MVC with some of the later builds (trying to find other issues) and I'm seeing some Roslyn IntelliSense problems with the Mvc.sln now. By closing out test explorer, property browser etc. I was able to open the solution, get it to restore, and build.

I ran into this guy:

Which seemed to go away when I forced a re-restore/re-build. After re-restoring/re-building successfully I then played around with some of the source files. Opening Mvc.sln => Mvc\src\Microsoft.AspNetCore.Mvc\MvcServiceCollectionExtensions.cs shows several errors indicating that Roslyn doesn't see some package refs:

In this case it's 1 of 2 directly referenced package refs <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="1.2.0-*" />.

Tried reproducing this on other projects with no avail. Anyone able to see this on their box with the Mvc.sln (checkout the nimullen/migration branch)? My VS is: 26208.0.d15rel

[mavasani]

@NTaylorMullen I'll investigate this now.

[mavasani]

@NTaylorMullen I am seeing different behavior then yours.

1. After cloning the repo and opening it in VS before doing any command line operations, restore fails for me with errors of the form Error occurred while restoring NuGet packages: The operation failed as details for project RoutingWebSite could not be loaded
2. I closed VS and ran build.cmd from command line, which worked fine.
3. Repen VS, solution opens fine, and I get proper intellisense without squiggles and no design time errors or warnings.
4. Build from VS succeeds with same set of warnings as from command line: Unable to determine active git branch. '.git/HEAD' file in unexpected format: 'd3cce192925ff41d0d79aba3728ab1ff80962a49'

I'll try to clean my enlistment and the nuget package cache and try the steps again. I'll file an issue on NuGet if (1) repros again.

[mavasani]

I am unable to repro the design time warnings about SkipCompilerExecution, but can repro the squiggles when opening certain source files - investigating further now.
382039 is tracking SkipCompilerExecution issues.

[Eilon]

BTW @NTaylorMullen is out sick today so it might be a short while until he can provide more details.

[mavasani]

Update: The squiggles from opening certain source files seems to be completely indeterministic, I haven't been able to repro it since I first saw it. Even the NuGet restore failures are not reproing after cleaning the enlistment and NuGet package cache and reattempting to build.

[NTaylorMullen]

@mavasani lol oh goodneses. Well, hopefully the blessed release that's supposed to fix the MVC issues will "just work" once it's out 😄

[Eilon]

To add another data point, @sebastienros is working on a solution w/ 100 projects (using the new csproj) and was also hitting enormous slowdowns. Here's one related VSFeedback item that he filed: https://vsfeedback/comment/806237.

But beyond that issue, he's been seeing slowdowns like what's discussed in this thread.

You can try out the branch here: https://github.com/OrchardCMS/Orchard2/tree/static

[mavasani]

@Eilon Thanks, I'll play around with the new solution.

[mavasani]

@Eilon I played around with the solution for a bit and noticed the biggest UI delays are coming from the Test Window, similar to the MVC solution - these don't appear after applying the patched Test Window bits, and I was able to do most of the operations fine in the IDE (open files, edit, intellisense, restore).

However, I hit a VS deadlock in the patched Test Window binary at the end of solution build - I am going to report the dump to the Test Window folks to investigate further.

[davkean]

@NTaylorMullen We're tracking those build errors here: #1554. I'll be investigating today.

[NTaylorMullen]

@davkean thanks, i'll keep an eye on that.

[NTaylorMullen]

Pinging this thread. Any ETA on a usable VS for MVC?

[mavasani]

Update: The Test Window fix has been checked in today, and the next D15Rel build should have this fix. I'll verify this tomorrow and post an update.

[davkean]

@NTaylorMullen We understand what the SkipCompilerExecution issue is (it's a bug in MSBuild). The workaround is to not use command-line restore when VS is open.

[mavasani]

I verified that the Test Window UI delay does not repro in build D15Rel 26223.1

[mavasani]

@NTaylorMullen at this point, let us use separate issues to track any functional issues - #1554 and dotnet/msbuild#1726 are tracking SkipCompilerExecution errors.

If you still see performance problems on MVC solution, please re-activate this issue and let us know as soon as possible.