[Tracker] MSBuild conversion issues

[NTaylorMullen]

This is just to track all the issues that I've run into so we can capture when they're resolved.

• Can't run GenerateResource Task. Can't run GenerateResource Task dotnet/sdk#346.
• Migrate doesn't respect global.json. https://github.com/dotnet/cli/issues/4568 / https://github.com/dotnet/cli/issues/4548
• Migrate does not understand transitive project references that have already been migrated. https://github.com/dotnet/cli/issues/4591. - By design unless specifying --skip-backup
• Migrate does not include transitive frameworkAssemblies. https://github.com/dotnet/cli/issues/4595.
• Migrating dotnet-test-xunit breaks test execution. https://github.com/dotnet/cli/issues/4629.
• Cannot add Microsoft.Net.Test.Sdk as a dependency of net451 projects. Cannot add Microsoft.Net.Test.Sdk as a dependency of net451 projects microsoft/vstest#190.
• dotnet test should have an indication that the project is being built. dotnet test should have an indication that the project is being built. microsoft/vstest#192.
• Property definition doesn't support CData. Property definition that impacts generated AssemblyInfo doesn't support CData  dotnet/msbuild#1294.
• Building project with twice (or more) transitive dependencies explodes. Building project with twice (or more) transitive dependencies explodes. dotnet/sdk#353.
• dotnet run requires framework to be specified when multiple are present dotnet run requires framework to be specified when multiple are present dotnet/sdk#358.
• Console.Out does not make its way to test execution output. Console.Out does not make its way to test execution output microsoft/vstest#195.
• ctrl + c doesn't stop test execution ctrl + c doesn't stop test execution microsoft/vstest#199.
• Trying to build projects with project references that target different SDK versions explodes. Trying to build projects with project references that target different SDK versions explodes dotnet/sdk#352.
• Custom XUnit test bits aren't used/run by the test runner Custom XUnit test bits aren't used/run by the test runner microsoft/vstest#291
• Test projects sometimes require <OutputType>Exe</OutputType>. OutputType in test project templates microsoft/vstest#287
• contentFiles support in nuget generated targets file. contentFiles support in nuget generated targets file NuGet/Home#3683.
• Transitive references. Transitive references dotnet/project-system#199.
• PackageReference to contentFiles package breaks compilation of 'net45x' tfms PackageReference to contentFiles pkg breaks compilation of 'net45x' tfms dotnet/sdk#495.
• dotnet-test may return exit code 0 even if some TFMs fail [IMPORTANT] dotnet-test should return 1 if test execution fails for any tfm microsoft/vstest#283
• Cross-targetting apps get wrong version of NETStandard.Library on .NETFramework Cross-targetting apps get wrong version of NETStandard.Library on .NETFramework dotnet/sdk#614
• Transitive package framework assembly references don't get included in build. Transitive package framework assembly references don't get included in build. dotnet/sdk#365.
• Test projects cannot be both desktop and non-desktop if dependencies changes based on RuntimeIdentifier. [Urgent] Test projects cannot be both desktop and non-desktop if dependencies changes based on RuntimeIdentifier. microsoft/vstest#198.
• Facades from desktop framework targeting pack are not emitted to .deps.json for PreserveCompilationContext Facades from desktop framework targeting pack are not emitted to .deps.json for PreserveCompilationContext dotnet/sdk#480.
• Cannot build web desktop web application without specifying RuntimeIdentifier. Cannot build web desktop web application without specifying RuntimeIdentifier. dotnet/sdk#357.
• TRX logger produces invalid XML file [Urgent] TRX logger produces invalid XML file microsoft/vstest#320
• Visual Studio executes tests in the Windows directory (C:\Windows\system32) https://developercommunity.visualstudio.com/content/problem/7956/current-working-directory-of-net-core-tests-is-set.html. Tracked here: WorkingDirectory coming incorrectly for .NET Core and .NetFramework  microsoft/vstest#311
• Cannot pack a .NET Core CLI tool Specifying package path doesn't work with dotnet pack NuGet/Home#4321

---

Bugs found after re-attempting migrate (In Progress...):

• Migration: excluded files need to be removed https://github.com/dotnet/cli/issues/5461
• dotnet migrate does not handle project.json embed behavior of the compiler/resources folder https://github.com/dotnet/cli/issues/5477
• Latest d15rel Visual Studio can't restore cross targeting projects Latest d15rel Visual Studio can't restore cross targeting projects NuGet/Home#4496
• Desktop test projects with class fixtures can fail to find tests. Desktop test projects with class fixtures can fail to find tests. microsoft/vstest#408
• runtimeconfig.json contains incorrect framework version runtimeconfig.json contains incorrect framework version dotnet/sdk#686
• xunit.runner.visualstudio cannot be used with MVC in test projects unless you add a reference to Microsoft.DotNet.InternalAbstractions. xunit.runner.visualstudio cannot be used with MVC in test projects unless you add a reference to Microsoft.DotNet.InternalAbstractions. xunit/xunit#1088
• Transitive references do not show all the time in the Dependency node Transitive references do not show all the time in the Dependency node dotnet/project-system#1423
• dotnet restore does not capture transitive framework assemblies from project references dotnet restore does not capture transitive framework assemblies from project references NuGet/Home#4412
• allow dotnet pack to pack nuspec file without needing a csproj file allow dotnet pack to pack nuspec file without needing a csproj file NuGet/Home#4254
• dotnet migrate should fail to migrate projects that have "shared" properties in their project.json. https://github.com/dotnet/cli/issues/5407, https://github.com/dotnet/cli/issues/5318
• DependencyContext cannot load entry assembly when used in a net46 test. [Urgent] DependencyContext cannot load entry assembly when used in a net46 test. microsoft/vstest#196.
• Overloaded test methods result in InvalidOperationException Overloaded test methods result in InvalidOperationException microsoft/vstest#392
• Solution with 56 projects is unsable once migrated to csproj. Solution with 56 projects is unsable once migrated to csproj. dotnet/project-system#1384
• AppDomain.CreateDomain cannot dynamically load test assembly AppDomain.CreateDomain cannot dynamically load test assembly microsoft/vstest#419
• Running tests that depend on string[] TypeDescriptor converters fail. Running tests that depend on string[] TypeDescriptor converters fail. microsoft/vstest#427
• corfxlab repro has some issues with Solution Open and Restore. NuGet Restore + VS performance / scalability on solutions with warnings (was: corfxlab repro has some issues with Solution Open and Restore) NuGet/Home#4617
• Auto-restore fails multiple times until all projects are loaded Feedback/Data?? -- Auto-restore fails multiple times until all projects are loaded NuGet/Home#4577
• "Unexpected dependency 'Microsoft.AspNetCore.Razor.Evolution' with no version number" opening MVC/CLI repros "Unexpected dependency 'Microsoft.AspNetCore.Razor.Evolution' with no version number" opening MVC/CLI repros NuGet/Home#4626
• SkipCompilerExecution Error SkipCompilerExecution Error dotnet/project-system#1554, ProjectInstance based build fails with a "Target not found exception" when the instance is mutated dotnet/msbuild#1726
• Project fault opening the MVC solution stating "Some data sources have regressed in their version number" Project fault opening the MVC solution stating "Some data sources have regressed in their version number" dotnet/project-system#1573
• NuGet background restore waits until VS has focus NuGet background restore waits until VS has focus NuGet/Home#4623
• Packing csproj with long description issues unresolvable warning about missing summary text Packing csproj with long description issues unresolvable warning about missing summary text NuGet/Home#4587
• Long test data results in Contents of string '{test name}' exceeds max of '449', string has been truncated. messages Long test data results in Contents of string '{test name}' exceeds max of '449', string has been truncated. messages xunit/xunit#1139
• SIGINT leaves dotnet processes running incorrectly. Causes problems on subsequent builds/runs. dotnet/cli#4856 and related dotnet run doesn't handle ctrl-c well dotnet/cli#812
  • not specific to MVC or even large repos
• dotnet msbuild commands hang with some command-line redirections dotnet/cli#5849
  • now dotnet msbuild commands sometimes hang after writing MSBuild_*.failure.txt files dotnet msbuild commands sometimes hang after writing MSBuild_*.failure.txt files dotnet/msbuild#1808
• Multitfm support for IDE (.net core) Multitfm support for IDE (.net core) microsoft/vstest#298
  • for MVC, this means only .NET Core tests run in Visual Studio
• MSB3270 warnings for .NET Framework test project that depends on an ASP.NET Core web site MSB3270 warnings for .NET Framework test project that depends on an ASP.NET Core web site dotnet/sdk#926
• Binding Redirects necessary to run Unit Tests on .NET Framework are not preserved when running in testhost Binding Redirects necessary to run Unit Tests on .NET Framework are not preserved when running in testhost microsoft/vstest#428
  • Re-enable functional tests on full .NET Framework Re-enable functional tests on full .NET Framework #5873 is a dupe / symptom of this

[TheRealPiotrP]

@srivatsn this is an interesting issue for us to track...

[NTaylorMullen]

Status:

• Migrated MVC src projects with work arounds.
• Migrated MVC sample project with work arounds.
• Migrated 1.5 MVC test projects but stopped due to the time spent working around known issues.

All issues found are listed above. Will continue migrating test projects when the vstest migration issues have been resolved.

[NTaylorMullen]

/cc @balachir

[NTaylorMullen]

Adding this guy: dotnet/sdk#480 - Facades from desktop framework targeting pack are not emitted to .deps.json for PreserveCompilationContext

Essentially preserveCompilationContext = true doesn't always work so any semi-advanced View will explode at runtime if run on the desktop framework. /cc @Eilon for visibility

[natemcmaster]

Here's another one to add: dotnet/sdk#495 PackageReference to contentFiles package breaks compilation of 'net45x' tfms

[natemcmaster]

It may be interesting to also track the CLI teams own attempts to migrate this repo: https://github.com/dotnet/cli/issues/5378

[dtivel]

Hey, @rrelyea, please check out the NuGet issues above.

[dougbu]

This doesn't exactly block our migration but NuGet/Home#4689, .csproj file not updated in Visual Studio until user does a Save All or closes solution will certainly cause developer confusion going forward. We often flip back and forth between command line and Visual Studio.

[Eilon]

@NTaylorMullen I guess we can close this right??

[NTaylorMullen]

@Eilon I'd say ya. There's still some open issues above but those are tracked elsewhere.