Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GC pressure Dependency.GetID #2918

Closed
lifengl opened this issue Oct 23, 2017 · 1 comment
Closed

GC pressure Dependency.GetID #2918

lifengl opened this issue Oct 23, 2017 · 1 comment
Assignees
@Pilchie
Labels
Tenet-Performance This issue affects the "Performance" tenet.
Milestone
15.6

Comments

@lifengl
Copy link
Contributor

lifengl commented Oct 23, 2017

In the trace, it accounts for 1% of allocation

Can we just use Tuple<string, string, string> to be the key, instead of merging them into a long string to use it as a dictionary key?
@davkean davkean added the Tenet-Performance This issue affects the "Performance" tenet. label Oct 23, 2017
@davkean davkean self-assigned this Oct 23, 2017
@davkean davkean added this to the 15.5 milestone Oct 23, 2017
@Pilchie Pilchie modified the milestones: 15.5, 15.6 Nov 1, 2017
@Pilchie Pilchie assigned Pilchie and unassigned davkean Jan 10, 2018
Pilchie added a commit to Pilchie/project-system that referenced this issue Jan 11, 2018
@Pilchie
Use a pooled StringBuilder in Dependency.GetID
ac9474d 
Traces showed this taking upward of 1% of allocations of opening a solution.

Fixes dotnet#2918.
@Pilchie Pilchie mentioned this issue Jan 11, 2018
Merged
Pilchie added a commit to Pilchie/project-system that referenced this issue Jan 17, 2018
@Pilchie
Use a pooled StringBuilder in Dependency.GetID
6e832b9 
Traces showed this taking upward of 1% of allocations of opening a solution.

Fixes dotnet#2918.
Pilchie added a commit to Pilchie/project-system that referenced this issue Jan 17, 2018
@Pilchie
Use a pooled StringBuilder in Dependency.GetID
4666ca2 
Traces showed this taking upward of 1% of allocations of opening a solution.

Fixes dotnet#2918.
@Pilchie
Copy link
Member

Pilchie commented Jan 23, 2018

Fixed in #3129

@Pilchie Pilchie closed this as completed Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pilchie Pilchie

Labels
Tenet-Performance This issue affects the "Performance" tenet.
Projects
None yet
Milestone
15.6
Development

No branches or pull requests
3 participants
@Pilchie @davkean @lifengl