Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up code actions code #10582

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

davidwengier
Copy link
Contributor

This PR is a style-only clean up of our code actions handlers and related code. Definitely could have gone further (more collection pooling, returning concrete types etc.) but I wanted to try to have it serve as an indication for what we consider our current idiomatic coding style* and to avoid conflicts with the extract to component work.

* Current style is subject to change at any time, and are not well documented. To quote a great Australian film, it's just the vibe.

@davidwengier davidwengier requested a review from a team as a code owner July 4, 2024 06:11
Copy link
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some thoughts, but overall like this change. Thanks for cleaning things up :) I didn't check code that was far outside of changed reasons

Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good topic for Monday codeabout - just talk through the list of (informal?) conventions we have to make it more explicit (unless there are more pressing topics)

@davidwengier
Copy link
Contributor Author

Seems like a good topic for Monday codeabout - just talk through the list of (informal?) conventions we have to make it more explicit (unless there are more pressing topics)

LOVE this idea.

Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Many welcome changes here. We can always argue over minor details, but the overall code improvement in this pull request is indisputable.

@davidwengier davidwengier merged commit 63e225d into dotnet:main Jul 9, 2024
12 checks passed
@davidwengier davidwengier deleted the CodeActionCleanup branch July 9, 2024 04:13
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 9, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 Preview 1 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants