Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pool CodeWriter ReadOnlyMemory<char> pages #10585

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Pool CodeWriter ReadOnlyMemory<char> pages #10585

merged 3 commits into from
Jul 16, 2024

Commits on Jul 4, 2024

  1. Pool CodeWriter ReadOnlyMemory<char> pages 

    These allocations are present in a customer trace I'm looking at, accounting for 1.4% of allocations in the VS process (around 100 MB).

The owner of the CodeWriter is already disposable, so making the CodeWriter disposable is trivial, and allows for all ReadOnlyMemory<char> pages added to _pages to be released back to a pool.
    @ToddGrun
    ToddGrun committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    b8ad94c View commit details
    Browse the repository at this point in the history

  2. Fix issue causing test failures 

    Code review feedback: Move CodeWriter ctor to make code cleaner
    @ToddGrun
    ToddGrun committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    eee4fe9 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. 1) Ensure CodeWriter disposal from other usage locations 

    2) Rename PageSize => MinimumPageSize
3) Add comment around subtle comparison
    @ToddGrun
    ToddGrun committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    96b3adf View commit details
    Browse the repository at this point in the history