Cohost: Support signature help #10595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgav
reviewed
Jul 9, 2024
.../Microsoft.AspNetCore.Razor.LanguageServer/Hosting/VSInternalServerCapabilitiesExtensions.cs
Show resolved
Hide resolved
alexgav
reviewed
Jul 9, 2024
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/SignatureHelp/SignatureHelpEndpoint.cs
Outdated
Show resolved
Hide resolved
alexgav
reviewed
Jul 9, 2024
...oft.VisualStudio.LanguageServices.Razor/LanguageClient/Cohost/CohostSignatureHelpEndpoint.cs
Outdated
Show resolved
Hide resolved
alexgav
reviewed
Jul 9, 2024
src/Razor/src/Microsoft.CodeAnalysis.Remote.Razor/SignatureHelp/RemoteSignatureHelpService.cs
Outdated
Show resolved
Hide resolved
DustinCampbell
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
I have nothing to add, but I up-voted some of @alexgav's comments.
# Conflicts: # eng/targets/Services.props
...zor/test/Microsoft.VisualStudio.LanguageServices.Razor.Test/Cohost/CohostEndpointTestBase.cs
Outdated
Show resolved
Hide resolved
…est/Cohost/CohostEndpointTestBase.cs Co-authored-by: Dustin Campbell <dustin@teamcampbell.org>
# Conflicts: # eng/Versions.props
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires dotnet/roslyn#74280, and won't even compile without it.
Part of #9519
This brings signature help to Cohosting. It's a pretty simply PR, for a pretty simple endpoint, as we just delegate, and there is no translation of delegated info. The interesting part here is that we use
System.Text.Jsonfor the remote signature help service, because it makes more sense to take advantage of the existing Json converters for the potential complexity of theSignatureHelpresult type.