Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NRE when invoking completion in empty document #10610

Merged
merged 3 commits into from
Jul 12, 2024

Commits on Jul 11, 2024

  1. Fix NRE when invoking completion in empty document

    In empty document completion context will have RazorDocumentSyntax as Owner. RazorDoucmentSyntax has null as the parent, which makes sense. However compiler thinks we can't have a null here, while obviously we do.
    
    I'm adding a null check and a test for this case. We would probably further discuss the implications here. I tried to track down how we get null in a non-nullable field, but it's a bit confusing since the class gets generated.
    alexgav committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    91c3fe7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    10db53c View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Fixing build

    alexgav committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    7d681d2 View commit details
    Browse the repository at this point in the history